`Soxr::process` crashes if used with more than one channel about libsoxr-rs HOT 12 CLOSED

My application now works with the latest git.

Thanks for the timely fix!

from libsoxr-rs.

Ai, it just show you should never rust a new release ;-) Thanks. I've removed the println in 0.2.7

from libsoxr-rs.

Thanks for this report. I've got a fix for a buffer problem locally (SEGFAULT). Do you have test or a minimal example that triggers this crash?

from libsoxr-rs.

I just pushed a fix for the SEGFAULT that I found. Could you check if this fixes your issue?

from libsoxr-rs.

I'll be able to test it with my code in about ten hours. Looking at the commit in question, it looks like that might fix the crash if set_input is used, but not if Soxr::process is used instead.

I produced a very barebones test program:

use libsoxr::Soxr;

fn main() {
    let mut soxr = Soxr::create(1.0, 2.0, 2, None, None, None).unwrap();
    let mut in_buf: [f32; 2000] = [1.0; 2000];
    for n in 1000..2000 { in_buf[n] = -1.0 }
    let mut out_buf: [f32; 4000] = [999.0; 4000];
    let (i, o) = soxr.process(Some(&in_buf[0..1000]), &mut out_buf[0..2000]).unwrap();
    println!("i = {}, o = {}", i, o);
    let mut has_negative = false;
    for v in out_buf.iter() {
        if *v < 0.0 { has_negative = true; break }
    }
    if has_negative {
        println!("Output contains negative samples. in_buf was read out of bounds!");
    }
    if out_buf[2000] != 999.0 {
        println!("Output sentinel overwritten. out_buf was written out of bounds!");
    }
}

from libsoxr-rs.

I was able to reproduce. I'll look into it further. Thanks!

from libsoxr-rs.

I have just pushed a fix which lets your example pass. I've added your example as a test. Could you check if this works for you? I'll then push to crates.io if it works

from libsoxr-rs.

The test_process_stereo_2 test should probably panic! instead of println! for the out-of-bounds checks. Also, you might want to add a note in the documentation for Soxr::process that "number of samples" and "number of array elements" won't be the same if the channel count is greater than one, so that nobody finds the return value surprising. Otherwise, looks good to me; though I won't be able to test it in my application until ten-ish hours from now.

from libsoxr-rs.

good points. I'll make asserts for these cases.

from libsoxr-rs.

I will push a new version tomorrow. Thanks for the report and testing!

from libsoxr-rs.

just pushed 0.2.6 to crates.io

from libsoxr-rs.

You left a debug println! on line 231 of soxr.rs in bb57921 :)

from libsoxr-rs.