Need to make sure that all device queries are wrapped in a try...except block, to take

Initially fixed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-

Parsers need rails about mrfreeze HOT 3 CLOSED

astrobokonon commented on June 29, 2024

Parsers need rails

from mrfreeze.

Comments (3)

astrobokonon commented on June 29, 2024

To clarify - the responses from the device will almost always be fine. If I ask a Sunpower GT what it's current power is, but at the same time (or just before) someone asks what its cold tip temperature is, the reply might be garbled, but still ... something. It's the parsing of that reply that will fail and what needs to be cleaned up. The actual communication failures should already be handled by the timeouts in the serialcomm.serComm() method.

from mrfreeze.

astrobokonon commented on June 29, 2024

Initially fixed in ed9278e by adding a simple try...except block to the publisher call outs in actions.queryAllDevices(). It can be expanded upon later (to catch ValueError vs. other errors) but this is good enough for now.

from mrfreeze.

astrobokonon commented on June 29, 2024

MrFreeze/mrfreeze/actions.py

Lines 56 to 68 in ed9278e

    
           try: 
        
               if reply is not None: 
        
                   if dvice.devtype.lower() == 'vactransducer_mks972b': 
        
                       pubs.publish_MKS972b(dvice, reply, db=dbObj, broker=bkObj) 
        
                   elif dvice.devtype.lower() in ['sunpowergen1', 'sunpowergen2']: 
        
                       pubs.publish_Sunpower(dvice, reply, db=dbObj, broker=bkObj) 
        
                   elif dvice.devtype.lower() in ['lakeshore218', 'lakeshore325']: 
        
                       pubs.publish_LSThing(dvice, reply, db=dbObj, broker=bkObj) 
        
                   elif dvice.devtype.lower() == 'arc-loisgettemp': 
        
                       pass 
        
           except Exception as err: 
        
               print("Unable to parse instrument response!") 
        
               print(str(err))

from mrfreeze.

Related Issues (16)

Recommend Projects

Parsers need rails about mrfreeze HOT 3 CLOSED

Comments (3)

Related Issues (16)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	try:
	if reply is not None:
	if dvice.devtype.lower() == 'vactransducer_mks972b':
	pubs.publish_MKS972b(dvice, reply, db=dbObj, broker=bkObj)
	elif dvice.devtype.lower() in ['sunpowergen1', 'sunpowergen2']:
	pubs.publish_Sunpower(dvice, reply, db=dbObj, broker=bkObj)
	elif dvice.devtype.lower() in ['lakeshore218', 'lakeshore325']:
	pubs.publish_LSThing(dvice, reply, db=dbObj, broker=bkObj)
	elif dvice.devtype.lower() == 'arc-loisgettemp':
	pass
	except Exception as err:
	print("Unable to parse instrument response!")
	print(str(err))