Code Monkey home page Code Monkey logo

pe's People

Watchers

 avatar

pe's Issues

Invalid data type is never filtered out

As a user, if I update my data manually, and set my quantity as a double (1.5), as I in fact have some half-packet of items in the fridge, this value is not filtered out. No warnings mention in the UG and prevents the program from starting as it throws an exception
Screenshot 2021-11-12 at 4.57.32 PM.png

Screenshot 2021-11-12 at 4.55.18 PM.png

Use indentations to help indicate different points

I believe that the second and third paragraphs are referring to one point. Could perhaps use indentation to indicate that paragraph 3 is just an example of paragraph 2, instead of being referred to as another separate point
Screenshot 2021-11-12 at 5.45.40 PM.png

Unable to retry adding to the shopping list, after a failed attempt

Let's say I want run out of wine, and I want to add wine to the shopping list. Unfortunately, I did not maanage to get it right in the first try. Now, I am unable to add wine to my shopping list... I have to re-add wine to my list and remove it before adding to my shopping list, such inconvenience for users.

Perhaps a better feature design could be possible or give an extra attempt for users to add a valid number
Screenshot 2021-11-12 at 5.13.06 PM.png

Issue with documentation symbols

When referring to a method inside a class, I believe that the proper notation is "Class#method()", instead of "Class.method()"
Screenshot 2021-11-12 at 5.25.08 PM.png

There is an inconsistency in storing and adding expired items

As a disgusting person, I want to keep expired items for future use. I am unable to add manually, but I can add expired items directly from the save file. Perhaps consistency is needed, either filter out the expired items, or allow expired items all together
Screenshot 2021-11-12 at 5.00.55 PM.png

Screenshot 2021-11-12 at 4.59.26 PM.png

Not filtering empty string in file

When I changed the food name burger into an empty string in the file, the values in the file is never filtered. Causing an exception to be thrown and program unable to start
Screenshot 2021-11-12 at 4.26.53 PM.png

Position of return arrow

For self invocations like in step 7 and 11, shouldn't the dotted arrows be on the right hand side, instead of left?
Screenshot 2021-11-12 at 5.27.17 PM.png

Shouldn't it be something like this?
Screenshot 2021-11-12 at 5.31.43 PM.png

Misleading error message

Error message states that "number can not be less than 0". This implies that 0 is allowed, which makes no sense(?)

Screenshot 2021-11-12 at 4.38.11 PM.png

Inconsistency with styling

In the architecture section, you styled the methods, like execute() here.
Screenshot 2021-11-12 at 5.29.18 PM.png

However, in the implementation section, methods are not styled in the same way. Perhaps having a consistent styling would help
Screenshot 2021-11-12 at 5.30.23 PM.png

Extra spaces is not filtered out from save file

As a user, if I edit manually from the file and insert an extra space, in this case, before "Qty", this saved data will not be filtered out and prevents the program from running, as an exception is thrown.
Screenshot 2021-11-12 at 4.52.13 PM.png
Screenshot 2021-11-12 at 4.52.40 PM.png

Notifications never appear

My notifications are on, and I expect a health reminder notice at the start of the program. It never appears though.
Screenshot 2021-11-12 at 5.10.10 PM.png

No filter for quantity above INT_MAX

As a super rich user, I would like to add billions of billions of food to my fridge. I set the quantity to a very huge quantity from the save file. And this value is read as a string as it is above INT_MAX, and not filtered out properly.
Preventing the program from starting all together, as it throws an exception
Screenshot 2021-11-12 at 5.04.23 PM.png

Screenshot 2021-11-12 at 5.05.23 PM.png

Missing Steps 13 and 14

Although it's just the steps to indicate the end of the method, you included it in other implementation explanations. So, I expect it to be in this explanation as well
Screenshot 2021-11-12 at 5.41.40 PM.png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.