Just two very similar functions about playrho HOT 4 CLOSED

Same functionality, yes. Different input parameters of course.

from playrho.

I feel bugged that they have different names and only one is noexcept. I think I'd also prefer to see one refactored into being a free function. Part of the problem was that I wanted a match with the accessing function. I.e. GetContactImpulses. That begot SetContactImpules. But left SetPointImpulses as an oddity. Hmm...

from playrho.

Thank you for pointing this out! This is appreciated by me.

from playrho.

Some updates on the changes I'm working on for this:

• I'm looking at renaming the Get*Impulses and Set*Impulses functions to GetImpulses and SetImpulses respectively. So while there will still be two similar functions, they'll both be named SetImpulses and just take different parameters.
• I've decided to try and do some of the refactoring of the Manifold that I'd previous made a project for. So far that's included the above mentioned renames, and also removing some unused interfaces from Manifold. Internally, I've also been reducing the syntax that at least for me seems more readable.
• I'm considering removing two bytes of state from Manifold and encoding that info without that memory.

from playrho.