Code Monkey home page Code Monkey logo

Comments (8)

yuval-realy avatar yuval-realy commented on June 14, 2024 1

Hey @TheRogue76
I'm dealing with the same error.
First time that I install lottie-react-native in version 6.7.0.
In Android everything is working great.

(I didn't install lottie-ios manually)
got this error in ios:

❌ /node_modules/lottie-react-native/ios/LottieReactNative/AnimationViewManagerModule.swift:1:8: compiling for iOS 12.4, but module 'Lottie' has a minimum deployment target of iOS 13.0: /Developer/Xcode/DerivedData/realy-hfcahlcvqnqyjzatzgdegijbjonx/Build/Products/Debug-iphoneos/lottie-ios/Lottie.framework/Modules/Lottie.swiftmodule/arm64-apple-ios.swiftmodule

from lottie-react-native.

TheRogue76 avatar TheRogue76 commented on June 14, 2024 1

Alright. Patch package Lottie React Native's podspec and make it explicitly 4.4.1 instead of ~> 4.4.1 and i will take a look this weekend

from lottie-react-native.

finalquest avatar finalquest commented on June 14, 2024 1

Alright. Patch package Lottie React Native's podspec and make it explicitly 4.4.1 instead of ~> 4.4.1 and i will take a look this weekend

forcing 4.4.1 in pods works as well.

I dont really know what the best approach is with this.
I dont really grasp the implications of increase the deployment target.
But if thats the simplest thing to do I can make a PR.

from lottie-react-native.

TheRogue76 avatar TheRogue76 commented on June 14, 2024 1

Alright. Patch package Lottie React Native's podspec and make it explicitly 4.4.1 instead of ~> 4.4.1 and i will take a look this weekend

forcing 4.4.1 in pods works as well.

I dont really know what the best approach is with this. I dont really grasp the implications of increase the deployment target. But if thats the simplest thing to do I can make a PR.

The thing is I do not understand why the podspec is not being respected the way it is intended. It shouldn't matter that Lottie iOS 4.4.2 came out, it should always use the specifications given. This means either something in the setup is messed up, or my understanding of some part of the code is incorrect.
The implication of bumping the target is that the newer version would not be compatible with certain older versions of React Native out in circulation. Only ones whose target is iOS 13 and above.
Feel free to do a PR and set the version of Lottie iOS to exactly 4.4.1. This should not be a breaking change and can be rolled out easily as 6.7.1. Once we get a better understanding of what went wrong, we can make a decision to either bump Lottie to 4.4.2 and drop older iOS versions, or something else. Appreciate your guys's patience so far.

from lottie-react-native.

rafael-urena-yoke avatar rafael-urena-yoke commented on June 14, 2024

Having the same issue with expo EAS throwing the error when trying to build for iOS.

Expo version: sdk49

Lottie Version: ^6.7.0

from lottie-react-native.

TheRogue76 avatar TheRogue76 commented on June 14, 2024

Hey @finalquest and @rafael-urena-yoke. Are you installing the lottie-ios package manually (via npm)? The LRN's pod spec does not specify going beyond 4.4.1, and as mentioned in the migration guide, you should remove any usage of lottie-ios from your NPM package and let LRN find it's own dependency.
Let me know if that is NOT the case, and i will take a look.

from lottie-react-native.

TheRogue76 avatar TheRogue76 commented on June 14, 2024

Update: Fixed under #1217. 6.7.1 inbound. Since RN 73 is the first one to bump the iOS target to 13, I will hold off on bumping to 4.4.2 for now until we decide to move the support window for React Native version to minimum 73, or if we do it beforehand, I will make sure to note it in the release notes so people know. Feel free to mark the issue as closed as soon as the release is available

from lottie-react-native.

TheRogue76 avatar TheRogue76 commented on June 14, 2024

https://github.com/lottie-react-native/lottie-react-native/releases/tag/v6.7.1

from lottie-react-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.