Implement rate limiting about tmdblib HOT 7 CLOSED

Should TMDbLib get an extra Retry-option for all methods, which will make it handle a "RateLimitException", by waiting the specified amount (+200ms for good measure) and then trying again?

Or should we simply throw a RateLimitException, and let the caller handle it?

Since we already use a Client object that people do their requests from, it'd be possible to expose the remaining limits (as described in the Talk page above), through some properties. Basically extend the TMDbRestClient.Execte() method to capture the response headers, and set properties accordingly. The TMDbClient object can then further expose the same thing through proxy-like properties.

from tmdblib.

I see 2 real usage scenario's for the library in this context:

• Using it in a front-end application with 'live' user interaction
• Using it as a service to scrape data automaticly

For scenario 1 it would be best to just throw an error so the user can be informed and for scenario 2 I would prefer a setting on the client object just maximizing my throughput for me without having to care with a property each call.

Exposing the response properties is a good idea, not that much effort and just gives the user something extra to play with if he really needs it.

Don't have the time to do any dev on it atm but at least we will have it worked out here when someone does have time :)

from tmdblib.

So basically, both things. I'm wondering if the rate limit should be an option on the class.. Like:
Client.HandleRateLimiting = true;

In which the methods will halt for X seconds if needed.

from tmdblib.

Yea that's what I would shoot for

from tmdblib.

The feature is now live.

https://www.themoviedb.org/talk/5317af69c3a3685c4a0003b1?page=1

from tmdblib.

ea8c2e1

from tmdblib.

Added test 6b47d82

from tmdblib.