Code Monkey home page Code Monkey logo

Comments (10)

matt-cook avatar matt-cook commented on July 17, 2024 1

New branch has been created with initial work on pop-up windows: https://github.com/zebradog/kiosk/tree/popup

These can be fairly complex, so likely we'll add support for simple dialogs prior to new windows or tabs: #52

from kiosk.

matt-cook avatar matt-cook commented on July 17, 2024

Looks like this could be done via the manifest: https://developer.chrome.com/extensions/contentSettings#property-popups we'll try and get it pushed into our next version.

from kiosk.

leoherzog avatar leoherzog commented on July 17, 2024

Any movement on this? Pages with a "Sign In with Google" button won't work because the pop-up doesn't pop-up. I tried adding "contentSettings.popups", to the manifest, but no luck.

from kiosk.

matt-cook avatar matt-cook commented on July 17, 2024

@xd1936 Not yet. It hasn't been an issue on any of our billable projects so it keeps getting bumped down in the queue.

from kiosk.

leoherzog avatar leoherzog commented on July 17, 2024

What is an overview of the changes that would need to be made? Is it just a manifest thing?

from kiosk.

matt-cook avatar matt-cook commented on July 17, 2024

The manifest update suggestion above is probably not applicable. Likely it would need to be handled by an event listener, as suggested here: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-apps/zzGLSiyWCnM/dMBcPBW2BUcJ

similar to how we handle permission requests for webcam/mic: https://github.com/zebradog/kiosk/blob/master/src/js/browser.js#L159

from kiosk.

leoherzog avatar leoherzog commented on July 17, 2024

@matt-cook This is great news! All I need is support for Google sign-in buttons, which cause a pop-up window to open and ask the user to log-in.

from kiosk.

leoherzog avatar leoherzog commented on July 17, 2024

I checked out the popups branch and tested it out, and Google sign-in buttons launch the sign-in screen perfectly, in full screen. After the user logs in, however, the pop-up does not go away and close itself, leaving the user with a blank full-screen window.

from kiosk.

matt-cook avatar matt-cook commented on July 17, 2024

@xd1936 does the latest version 5.8.0 work for you? I've added support for new windows.

from kiosk.

matt-cook avatar matt-cook commented on July 17, 2024

This issue was moved to https://discuss.kiosk.cook.company/t/enable-pop-up-windows/149

from kiosk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.