View not taken from base theme (OSOE-529) about hosting-media-theme HOT 13 CLOSED

Do you have any hints by chance, @barthamark?

from hosting-media-theme.

Do you have any hints by chance, @barthamark?

Any views from the base theme (i.e., anything outside media theme) should work. I'm not sure why it doesn't happen, though, from the top of my head. 🫤

from hosting-media-theme.

Fixed in #33

from hosting-media-theme.

@davidpuplava the original bug still persists

from hosting-media-theme.

@davidpuplava the original bug still persists

Ok I’ll take a look

from hosting-media-theme.

Ok I’ll take a look

Thank you!

from hosting-media-theme.

Hey guys, I might've misunderstood something here. To clarify, you can override everything that you would be able to override using Orchard Core's Templates feature; simply because it's using the same extension point. So AFAIK this file can't be overriden.

from hosting-media-theme.

It's not about overriding, but rather, that view form the base theme is not taking effect.

from hosting-media-theme.

It's not about overriding, but rather, that view form the base theme is not taking effect.

This is what I understand the issue to be. Before #33, I reproduced the issue by

1. Creating a new tenant with TheBlog theme,
2. Ran recipes for Lucene Search and Query to get the /search form page
3. Observed that the tenant's /search page looked as expected with the header section with the image
4. Then made the MediaTheme the current theme
5. On AdminUI's Configuration->Media Theme page, set the Base Theme to "The Blog Theme"
6. Observed the tenant's /search page was missing the astronaut image and the header section altogether
7. After the fix in #33, navigating to the /search page using TheMediaTheme configured to use "The Blog Theme" as the base, I observed the header as expected

I pulled the latest dev branch and it works using the above steps. @wAsnk or @Piedone is there a different set of steps to reproduce the issue?

from hosting-media-theme.

In the 2nd point what recipes are you running exactly and do you do anything else?

from hosting-media-theme.

I tried your steps and the result is this for me:

from hosting-media-theme.

The fix works in OSOCE but didn't work on DotNest because actually not the latest version of the submodule was pulled in... So, now https://lettersfromfiume.com/Search works too!

Sorry about the false alarm.

from hosting-media-theme.

Yeah, sorry that was probably a misclick on my side then...

from hosting-media-theme.