Comments (3)
While I'd agree that both of these could have a Pod impl (where T:Pod), I'm not so confident that generically that's always true.
but then again that can maybe be said of some C structs. hmm.
from bytemuck.
I'm not so confident that generically that's always true.
#[repr(transparent)]
totally guaranties that if it is.
For #[repr(C)]
structs it would be much harder to do I think, this is why my suggestion is to do that for #[repr(transparent)]
types only, at least at first.
from bytemuck.
Hm, I suppose if all of the ZST values in the type are also Pod then that would work out correctly. So I think we could do this if that check was part of the derive. Even if it's overly conservative, that's better than being too permissive with an unsafe trait, and people can always bypass the derive's logic and just impl the trait themselves if they are that confident they know the situation best.
As with other derive changes, I don't know that code as well and so I'm very unlikely to make the change myself. However, I could accept a PR for it.
from bytemuck.
Related Issues (20)
- Crate documentation is misleading, implies `Pod` required for all functions. HOT 3
- the `FooBits` type generated by `#[derive(CheckedBitPattern)]` should implement `NoUninit` if `Self` is `NoUninit` HOT 3
- False positive derive error for `TransparentWrapper` around types like `Box` HOT 1
- Potential rustc bug related to deriving ByteEq HOT 2
- no-uninit trait with interior mutability HOT 6
- Deriving Pod for arbitrary generic types HOT 1
- Why use from_bytes when you can use pod_read_unaligned? HOT 5
- Build error on nightly-2024-02-05 HOT 1
- Bytemuck 1.14.2 does not build on stable HOT 1
- Feature request: Casting owned slices or vec, I.e. Box<[u64]> to Box<[u8]> or Vec<u64> to Vec<u8> HOT 4
- conversion from `&[u8]` to `&[T]`? HOT 4
- Allow deriving `Zeroable` for enums which are `#[repr(u32, i8, etc..)]` HOT 2
- Address safety invariants in documentation HOT 1
- No documentation for the FooBits public type generated by derive(CheckedBitPattern) HOT 1
- Casts and conversions for owned, boxed slices HOT 5
- `#[derive(TransparentWrapper)]` doesn't work with `where` clause generic bounds. HOT 1
- Unsound usages of unsafe implementation from different generics HOT 2
- Unsound usages of unsafe implementation from `[u8]` to `T` HOT 2
- impl `ZeroableInOption` for all `Zeroable`? HOT 1
- Support `f16` and `f128` under a nightly flag HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bytemuck.