Are there plans to implement a guaranteed-stable sorting method? about lodash HOT 8 CLOSED

More info on V8's unstable sort here:
http://code.google.com/p/v8/issues/detail?id=90

from lodash.

I'll do some research and see what the cost would be, that will help me figure out how to handle it. Worst case there can at least be a build option for it.

from lodash.

For what it's worth, here's how I implemented stable sorting:

In the beginning of _.sortBy, when it's mapping the list of values onto criteria&value objects, I also add the index as a property:

result[index] = {
    criteria: callback(value, index, collection),
    value: value,
    index: index
}

And I created a modified compareAscending that looks at index when the criteria values are equal.

function compareAscending(a, b) {
    var ai = a.index;
    var bi = b.index;
    a = a.criteria;
    b = b.criteria;

    if (a === undefined) {
      return 1;
    }
    if (b === undefined) {
      return -1;
    }
    return a < b ? -1 : a > b ? 1 : ai < bi ? -1 : 1;
  }

from lodash.

And I created a modified compareAscending

Awesome! I will patch this. It might slip into the 0.5.0 release.

from lodash.

Wait, what if both criteria are undefined?

from lodash.

@ricklerre Good call. I'll patch that up.

from lodash.

patched here.

from lodash.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from lodash.