Code Monkey home page Code Monkey logo

Comments (10)

jdalton avatar jdalton commented on April 27, 2024

Can you please try the edge repo version of Underscore. This sounds like it could be a sparse array issue, which the edge repo version of Underscore doesn't support (but doesn't support inconsistently so for it to fail you would need to check it in IE8 or less).

from lodash.

3rd-Eden avatar 3rd-Eden commented on April 27, 2024

Upgrading to edge repo version of underscore in IE8 does show the same error I'm currently seeing in every browser with lodash.

So it does sound like the sparse array issue indeed ;)

from lodash.

jdalton avatar jdalton commented on April 27, 2024

Upgrading to edge repo version of underscore in IE8 does show the same error I'm currently seeing in every browser with lodash.

Bummer about the sparse array use, but also high five because this underscores why I forked.
One of the big reasons I forked and started Lo-Dash was to have better cross-browser consistency in the utility belt's API. In this case it's consistently reproducing an error and in others it's consistently iterating over object properties.

So it does sound like the sparse array issue indeed ;)

Lo-Dash doesn't support sparse arrays because we don't use native ES5 array methods and so don't have to follow spec to the letter. This allows Lo-Dash to optimize for the common case, non-sparse, and increase performance in all browsers.

from lodash.

3rd-Eden avatar 3rd-Eden commented on April 27, 2024

Well this does mean that lodash is no longer a drop-in replacement for underscore as it does break code that was written against underscore.js

from lodash.

jdalton avatar jdalton commented on April 27, 2024

Well this does mean that lodash is no longer a drop-in replacement for underscore as it does break code that was written against underscore.js

Lo-Dash has some small differences which usually aren't a problem as I side on documented/tested/popular usage.
Your issue falls into the edge case category and as luck has it will have the same issue once Underscore version bumps.

from lodash.

3rd-Eden avatar 3rd-Eden commented on April 27, 2024

This issues and edge cases should probably be documented somewhere so people are actually aware of the subtile but potential destructive differences between lodash and underscore.

Also edge-case or not.. It does mean that lodash is not a drop-in replacement of underscore.

from lodash.

jdalton avatar jdalton commented on April 27, 2024

This issues and edge cases should probably be documented somewhere so people are actually aware of the subtile but potential destructive differences between lodash and underscore.

Sure, that's a good idea.

Also edge-case or not.. It does mean that lodash is not a drop-in replacement of underscore.

No, for most devs Lo-Dash is a drop-in replacement for Underscore.

from lodash.

feronovak avatar feronovak commented on April 27, 2024

I agree with 3rd-Eden, it shouldnt be called 100% drop-in replacement for underscore. It simply behaves differently in some cases

from lodash.

 avatar commented on April 27, 2024

Well this does mean that lodash is no longer a drop-in replacement for underscore as it does break code that was written against underscore.js.

Well...yes and no. Your code will still break when the next version of Underscore is officially released, as they have removed most of their sparse array handling code.

from lodash.

lock avatar lock commented on April 27, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from lodash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.