Code Monkey home page Code Monkey logo

Comments (4)

jdalton avatar jdalton commented on April 28, 2024

@pepkin88 Thanks for digging into this! You bring up a very good point. Strict mode has saved my bacon a few times while deving Lo-Dash but this is a cross-browser and Underscore lib issue.

The good news:
Because I use compilation for methods like extend I can opt out of strict mode for them and not out of strict mode for the entire lib. I will review the code to see if that is a doable solution :D

from lodash.

jdalton avatar jdalton commented on April 28, 2024

@pepkin88 Ok, so after some review I think this is a doable fix. There are 3 methods that augment foreign objects (_.extend, _.defaults, and _.bindAll). Two of them, _.extend and _.defaults, are compiled (they even use the same base template data to compile) so they are easiest to tweak. So that leaves _.bindAll. Don't worry about that one, I'll take care of it :P

from lodash.

fatso83 avatar fatso83 commented on April 28, 2024

I was assuming lodash to throw on merging frozen objects, so this bit us recently. Took a decent amount of digging to find this was the cause, as I (falsely) assumed a strict mode function calling a non-strict function from another module would still be in strict mode ...

from lodash.

lock avatar lock commented on April 28, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from lodash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.