deleting record(removing association) from hasMany relationship array not persisting(getting saved) on localstorage. about ember-localstorage-adapter HOT 9 CLOSED

Does record.destroy() work?

Do you think you would be able to send a PR with a failing spec? There are many there already in which you can mirror.

from ember-localstorage-adapter.

I don't know if i am right but on seeing code of local_adapter.js I find that deleteRecord doesnt deal with serialization whereas update and create do.Maybe thats why error is creeping.
Here is snippet of code:

  createRecord: function (store, type, record) {
    var namespaceRecords = this._namespaceForType(type),
        recordHash = record.serialize({includeId: true});

    namespaceRecords.records[recordHash.id] = recordHash;

    this.persistData(type, namespaceRecords);
    return Ember.RSVP.resolve();
  },

  updateRecord: function (store, type, record) {
    var namespaceRecords = this._namespaceForType(type),
        id = record.get('id');

    namespaceRecords.records[id] = record.serialize({ includeId: true });

    this.persistData(type, namespaceRecords);
    return Ember.RSVP.resolve();
  },

  deleteRecord: function (store, type, record) {
    var namespaceRecords = this._namespaceForType(type),
        id = record.get('id');

    delete namespaceRecords.records[id];

    this.persistData(type, namespaceRecords);
    return Ember.RSVP.resolve();
  }

from ember-localstorage-adapter.

Any views on this problem??

from ember-localstorage-adapter.

@oblongta I'm not working on any project using LS right now, but I can review code help with what I can do.

Do you think you would be able to send a PR with a failing spec? There are many there already in which you can mirror.

That way I could take a quick look and debug fast.

from ember-localstorage-adapter.

Most frameworks have special commands to handle deletion of relationship records, such as belongsTo and hasMany. Ember Data generally does not handle these cases and you seem to have to delete everything you want deleted. So if you want to delete, say an employee, from a company, where company hasMany employees. Then I assume the way is to first remove the employee from the company through something like this:

var employee = this.get('model');
var company = employee.get('company');
company.get('employees').removeObject(employee);
company.save();
employee.deleteRecord();
employee.save();

This should delete the employee for good.

from ember-localstorage-adapter.

@oblongta can we close this?

from ember-localstorage-adapter.

I'm using LS with ember data 1.0.0 beta 8.
lets take the employee and company example, when I load all the records from LS, then following will delete both employee and also its relation in company:

var employee = this.get('model');
var company = employee.get('company');

employee.deleteRecord();
employee.save().then(function(){
    company.save();
});

however when the record for employee is just created on the same session (and is added to company.employees using addObject, that code does remove the employee record but NOT the relation in company.

I'm not an ember profi so I cant say if this is a ember data problem that does not maintain the relation for newly created records or is it from LS.

however the code @bjarkehs provided always does the right job.

from ember-localstorage-adapter.

@mohamnag That's an ember data issue. I ran into the same problem using the DS.ActiveModelAdapter. Thankfully I found this thread and another one that further describes the issue. emberjs/data#1303

from ember-localstorage-adapter.

I also believe this to be an Ember Data problem and thus not specific to LSA.

from ember-localstorage-adapter.