Code Monkey home page Code Monkey logo

Comments (5)

dnlobo avatar dnlobo commented on August 16, 2024 1

Hi, thank you for reporting the error. There was indeed a bug in the code. It is fixed now and a new version of mergem was pushed to pypi (0.21.5).

I tried your test with those two models from the CarveMe repo and it worked.

from mergem.

dnlobo avatar dnlobo commented on August 16, 2024 1

Yes, the results can be different depending on the order of the merge. Notice that the output model always contains all the metabolites and reactions of the first model, and the rest are merged into this one as much as possible. This is important in the case of a model containing synonymous metabolites (such as NH2 and NH3). In this case, both metabolites will be preserved if that model is the first, but one of those metabolites will be lost if the first model does not contain both metabolites. These differences can result in different number of reactions.

If your computer cannot handle 200 models at once, you could try merging them one at a time in a for loop, starting with your best base model:

# A list with your 200 models
models = ["test/Abiotrophia_defectiva_ATCC_49176.xml", "test/Acidaminococcus_fermentans_DSM_20731.xml", ...] 

merged_model = mergem.load_model(models[0])

for model_index in range(1, len(models)):
   merged_model = mergem.merge([merged_model, models[model_index]], 1)

from mergem.

dnlobo avatar dnlobo commented on August 16, 2024 1

That parameter only affects the objective function. What I wrote is true for all the metabolites, and hence reactions in the model. Either parameter would work, depending on what you want.

from mergem.

hebamuh68 avatar hebamuh68 commented on August 16, 2024

I had another question, my device crashed when I worked on 200 models at once, so I though to merge each 50 together then the 4 result files i'll merge to one..

I tested on smaller file
1_merge => 3 models
2_merge => 3 models
and this was the result of merging (1_merge + 2_merge)

image

but when i merged the 6 models at once, I git this result, which the number of reactions is more than above

image

so I was wondering if there's any mistake in this techniqe about merging the outcome of the merge

from mergem.

hebamuh68 avatar hebamuh68 commented on August 16, 2024

but isn't this in case i put the -obj as 1?
am using => -obj merge,, which means will merge all _ which i want to get _ ?

from mergem.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.