Hey there, thanks so much for your work on this handler, it's exactly what I was looki

<div class="highlight highlight-source-go notranslate position-relative overflow-auto"

Consideration of an alternative approach when printing structs about tint HOT 3 CLOSED

lmittmann commented on August 21, 2024

Consideration of an alternative approach when printing structs

from tint.

Comments (3)

lmittmann commented on August 21, 2024 1

Yes, this would definitely break with the conventions of TextHandler. Although what you describe is the default behavior of the JSONHandler.

However, I think there is a good equivalent solution to zerolog, the slog.LogValuer.

func (p Person) LogValue() slog.Value {
	return slog.GroupValue(
		slog.String("name", p.Name),
		slog.Int("age", A.age))
}

The output format is a little different though. ..., "person", p,... would become person.name=John person.age=30

from tint.

fgimian commented on August 21, 2024 1

func (p Person) LogValue() slog.Value {
	return slog.GroupValue(
		slog.String("name", p.Name),
		slog.Int("age", A.age))
}

Actually, that's perfect and honestly nicer output than the JSON output as it is more human friendly. Thanks so much for the reply and tip, I wasn't aware of this method.

I'm happy to close this issue 😄
Fotis

from tint.

fgimian commented on August 21, 2024

Just to give you an idea of how I accomplished this locally while testing:

handler.go

...
func appendValue(buf *buffer, v slog.Value, quote bool) {
...
-               if tm, ok := v.Any().(encoding.TextMarshaler); ok {
-                       data, err := tm.MarshalText()
-                       if err != nil {
-                               break
-                       }
-                       appendString(buf, string(data), quote)
-                       break
+               if jm, err := json.Marshal(v.Any()); err == nil {
+                       appendString(buf, string(jm), false)
+               } else {
+                       appendString(buf, fmt.Sprintf("%+v", v.Any()), false)
                }
-               appendString(buf, fmt.Sprint(v.Any()), quote)
...

And my example:

type Person struct {
	Name string `json:"name"`
	Age  int    `json:"age"`
}

func main() {
	tintOptions := tint.Options{
		Level:      slog.LevelDebug,
		TimeFormat: time.DateTime,
	}
	slog.SetDefault(slog.New(tintOptions.NewHandler(os.Stdout)))

	person := Person{
		Name: "John",
		Age:  30,
	}
	slog.Info("This is the person", slog.Any("person", person))
}