Code Monkey home page Code Monkey logo

Comments (3)

lmgonzalves avatar lmgonzalves commented on August 10, 2024

Hi, thanks for contributing!
Please help me understand this, because stop function is actually public. So, you don't need:

this.stop = this.stop;

But seems a good idea to call stop in the constructor instead setting timer and animationTimer to null. Something like:

this.draw(this.begin, this.end, 0, {circular: this.circular});
this.stop();

from segment.

driedel-zz avatar driedel-zz commented on August 10, 2024

Hi :)

I'm sorry, I suggest something that already works :(

I was trying to stop just setting the .draw to zero, but it doesn't stop the animation... so I look at your code the stop function and don't try to call it because it was not listed in the constructor..

I've made an example in JSFiddle, and it works perfectly.

https://fiddle.jshell.net/driedel/fcmy8dq9/

Look at the updateTimer function and you will understand my mistake.

from segment.

lmgonzalves avatar lmgonzalves commented on August 10, 2024

mmm, I see.
Ok, I will document stop function in README as soon as possible :)
Thanks!

from segment.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.