Code Monkey home page Code Monkey logo

Comments (6)

ashermancinelli avatar ashermancinelli commented on July 17, 2024 1

The fix has been merged into develop and I have validated the patch myself. Thanks for the help!

from umpire.

davidbeckingsale avatar davidbeckingsale commented on July 17, 2024

The hip_runtime target comes from BLT. When you build a HIP-enabled Umpire it is required to be linked to the HIP runtime library, which is most easily done by linking with hipcc. The target handles this.

How do you support HIP compilation in your application?

from umpire.

ashermancinelli avatar ashermancinelli commented on July 17, 2024

Perhaps I'm just misusing the library. According to this issue in ROCm repo, we set C++ compiler to hip clang and link against hip::device for device code, as discussed on this ROCm documentation page. Do you see anything immediately wrong with this, and is there additional documentation for using Umpire with hip?

from umpire.

ashermancinelli avatar ashermancinelli commented on July 17, 2024

For additional context:

  • The error occurs in the link step, the sources with RAJA kernels using HIP policies compile fine.
  • The final linked targets also link to cmake target hip::device, and are confirmed to use --hip-link

from umpire.

ashermancinelli avatar ashermancinelli commented on July 17, 2024

We ran into this issue with RAJA - would you like me to raise an issue on that repo as well? After removing the hip_runtime targets manually our entire stack built and ran successfully.

from umpire.

davidbeckingsale avatar davidbeckingsale commented on July 17, 2024

I'm hopeful that #541 will help - if you would like to try and build and install that branch and see if the issue goes away that would be super helpful. I can than make the same change to RAJA.

from umpire.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.