Comments (5)
Ok, makes sense, but do you have any advice about what to do for Windows, then?
from osmid.
Yeah, Windows is always a bit of a special case, I guess. ;-)
My proposal is to allow devendoring, not to enforce it. For environments such as Windows it could still remain vendored. However, other operating systems such as Linux have different requirements.
If allowing to use a system version of spdlog is done via a CMake option (e.g. USE_SYSTEM_SPDLOG
), it should be fairly trivial: just default to OFF
).
If it is ON
, cmake discovers and uses the system version, if it is OFF
the vendored version is used.
If the target include paths are set correctly there should not even be any difference for the code (and all can be set to global includes).
Closing, I guess it would also be great to upgrade the vendored version (to remain in sync with its upstream).
from osmid.
@dvzrv , ok, I have put the change in the branch spdlog_from_distro
. Can you please have a look and let me know if that is what you were expecting?
I have also updated the bundled spdlog in that branch to make it compatible with the one I see packaged for my Linux distribution, so that I can use the same source code in the application.
If this is what you were looking for, I'll merge into master and tag a new release.
from osmid.
Argh, sorry... I forgot about this ticket!
I'll look into this tomorrow for sure as I have to update the package... :)
from osmid.
Okay, I have commented on a small issue with the fix.
Unfortunately we are already at spdlog 1.7.0 and building against it does not work:
osmid-0.8.0-devendor_spdlog.txt
from osmid.
Related Issues (20)
- Terminal -h documentation does not expose OSC API HOT 1
- OSC heartbeat uses nonstandard argument array type HOT 5
- Support for multiple similar out ports HOT 9
- template compilation errors on Raspbian for RPi HOT 4
- o2m: messages not going to the MIDI device HOT 1
- Need to be able to enable disable monitor for console and OSC separately HOT 2
- MIDI -> OSC pitch bend messages should send the full pitch bend value, not in 2 byte chunks
- Send MIDI channel with offset 1, not 0
- Have device ids start from 1, not 0 HOT 2
- Linux Midi port names HOT 4
- m2o fails on Ubuntu 16.04 when used with Sonic Pi midi HOT 3
- release for packaging HOT 8
- Under Linux, ALSA or JACK or both? HOT 1
- o2m raw messages sending to all devices even when a specific device is given HOT 2
- OSC bundles are not decoded (in Sonic Pi at least) HOT 2
- prollem with osmid on raspberry pi 64bit OS HOT 11
- OSC message format is not "symmetric" HOT 7
- Debian Bullseye needs libx11-dev
- m2o in background from script not running
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osmid.