Comments (3)
Just want to question a4f2487. Is there a good rationale for it? One rule I try to abide by is "only have one name for a thing, to the extent it is possible". So it should be type Func xor func NewFunction.
I'd say it's a good rule in general. The reason really is that we will end up typing ir.NewFunc quite often, and thus making it shorter makes it more pleasant to use. This is analogous to the func
keyword in Go.
As for having the same name for the type as the construction, sure. We already have another case where the constructor is an abbreviated version of the type name, ir.NewBlock returning *ir.BasicBlock.
There are also two constructors where the name does not match, but that is by design. ir.NewGlobalDecl and ir.NewGlobalDef both return *ir.Global.
from llvm.
I think I'm starting to lean more towards your suggestion, to make consistent use of one name throughout. I'd therefore like to get this in place before tagging the final v0.3 release.
The two primary API changes are as follows:
- rename
type Function
totype Func
- rename
type BasicBlock
totype Block
- rename
func NewGlobalDecl
tofunc NewGlobal
- keep
func NewGlobalDef
as a more specialized constructor for creating global variable definitions. It is also possible to use theInit
field directly, e.g.g := ir.NewGlobal("foo", types.I32); g.Init = constant.NewInt(types.I32, 42)
- keep
If we find any other inconsistent use of naming, lets add it to this issue.
from llvm.
I think we can close this issue as the constructor and type names are now consistent. If we find any others, we can simply re-open it later. Thanks for reporting it @pwaller!
from llvm.
Related Issues (20)
- `SRet` struct location HOT 3
- How to use Function Pointers? HOT 3
- Wrong function pointer type HOT 1
- indirect br only takes constant addr HOT 1
- Returning void as a value HOT 3
- update llir/llvm to support 14.0 HOT 2
- update llir/llvm to support LLVM 15.0 HOT 7
- How to have two structs referencing eachother HOT 4
- How to convert to exe? HOT 3
- `module.NewTypeDef` has unexpected side effects HOT 17
- Provide working Hello, World example HOT 1
- support llvm 16.0.0 HOT 2
- incorrect cmpxchg signature HOT 4
- How to generate ir for embedded struct? HOT 6
- Convert to string HOT 1
- Hello 10 instead of Hello world. Passing a IntPtr to printf (go - LLIR/LLVM) HOT 3
- malloc and strcpy in LLVM HOT 1
- unable to generate LLVM: structure, external , noundef and ptr HOT 1
- No way to find underlying type of pointer or array HOT 1
- How to compile LLVM IR to machine code programatically? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from llvm.