astx/fix: doesn't handle quoted names correctly about llvm HOT 1 CLOSED

This issue has been resolved in the latest revision of llir/llvm.

Given the input:

define void @fn() {
    call void @"quoted1"()
    call void @"quoted 2"()
    ret void
}

declare void @"quoted1"()
declare void @"quoted 2"()

The following example program runs successfully:

package main

import (
	"fmt"

	"github.com/llir/llvm/asm"
)

func main() {
	m, err := asm.ParseFile("foo.ll")
	if err != nil {
		panic(err)
	}
	fmt.Println(m)
}

And produces the following output:

define void @fn() {
	call void @quoted1()
	call void @"quoted 2"()
	ret void
}

declare void @quoted1()

declare void @"quoted 2"()

Notice that identifiers in the output are only quoted if required (i.e. containing special characters or spaces).

Closing this issue for now. If you notice any other issues, just re-open or report back in a new issue.

Cheers,
Robin

from llvm.