Comments (4)
I just finished adding initial support for device group messaging in f1b3161. I would appreciate it if you could test it out and provide any feedback or issues you may encounter.
from php-gcm.
I've just checked the code and it looks great! I couldn't test it yet but I'll do it soon (probably tomorrow) and give you a better feedback.
from php-gcm.
It's working great, thanks for the enhancement. I only have few questions.
1- Are you implementing the send method for group operations?
2- Shouldn't we make the SENDER_ID an attribute of the Sender class?
3- GCM sometimes returns 200 but the operation is not fully successful. For example, when we try to create a group that already exists we get a HTTP 200 code and a message: ''{"error":"notification_key already exists"}'". There are similar cases like this one. Should we catch these "errors" ?
Please let me know if you need any help with these improvements!
from php-gcm.
- Yes, the responses are different and are not parsed correctly right now. Either the
send
method needs to parse either possible response or there needs to be a separate send method. - Yes, I think that makes more sense in the long run.
- I ran across this when adding support for groups, but I didn't notice that they were 200 responses. It's unfortunate that part of their API respects status codes and part of it does not. The only solution would probably be to check for the presence of the top level error key when deciding if the request was a success or not.
from php-gcm.
Related Issues (20)
- Google Cloud Messaging (GCM) Notification receiving with logs detail HOT 2
- Should be able to specify curl cainfo cert path HOT 1
- how to set notification payload? HOT 6
- Add support for sending topic messages HOT 1
- Simultaneous sending limit HOT 4
- wrong $retries variable HOT 1
- Support for Web Push Payload Encryption HOT 4
- Composer installs old version HOT 8
- Release 1.1.1 has outdated end point HOT 1
- Put a release onto composer? HOT 1
- Complex data in push message HOT 1
- How can I send Big Picture Style notification with this? HOT 1
- Support for Firebase Cloud Messaging (FCM) HOT 1
- I have a question about php-gcm. HOT 1
- Example usage
- please update readme code base has changed
- About your class
- Firebase server sends old messages
- Migration to FCM HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-gcm.