Comments (3)
迭代删除有问题,删除之后指针变化了
from gostl.
迭代删除有问题,删除之后指针变化了
你的补丁在删除的时候避免使用了后继节点来迭代,但是我觉得可能下面的方法更好:
不要删除后继指针,而是把后继节点和要删除的节点位置交换(Relink),再把要删除的节点剥出来,这样后继节点不会因为删除而失效
func (rb *RbTree) Delete(n *Node) {
erasedNode := n
var fixNode, fixNodeParent, pNode *Node
pNode = erasedNode
if pNode.left == nil {
fixNode = pNode.right
} else if pNode.right == nil {
fixNode = pNode.right
} else {
pNode = successor(n)
fixNode = pNode.right
}
if pNode == erasedNode {
fixNodeParent = erasedNode.parent
if fixNode != nil {
fixNode.parent = fixNodeParent // link up
}
if rb.root == erasedNode {
rb.root = fixNode // link down from root
} else if fixNodeParent.left == erasedNode {
fixNodeParent.left = fixNode // link down to left
} else {
fixNodeParent.right = fixNode // link down to right
}
} else {
//>> pNode is erasedNode's successor, swap(pNode, erasedNode)
erasedNode.left.parent = pNode // link left up
pNode.left = erasedNode.left // link successor down
if pNode == erasedNode.right {
fixNodeParent = pNode // successor is next to erased
} else { // successor further down, link in place of erased
fixNodeParent = pNode.parent // parent is successor's
if fixNode != nil {
fixNode.parent = fixNodeParent // link fix up
}
fixNodeParent.left = fixNode // link fix down
pNode.right = erasedNode.right // link next down
erasedNode.right.parent = pNode // right up
}
if rb.root == erasedNode {
rb.root = pNode // link down from root
} else if erasedNode.parent.left == erasedNode {
erasedNode.parent.left = pNode // link down to left
} else {
erasedNode.parent.right = pNode // link down to right
}
pNode.parent = erasedNode.parent // link successor up
pNode.color, erasedNode.color = erasedNode.color, pNode.color // recolor it
}
if erasedNode.color == BLACK { // erasing black link, must recolor/rebalance tree
rb.rbDeleteFixup(fixNode, fixNodeParent)
}
rb.size--
}
from gostl.
迭代删除有问题,删除之后指针变化了
你的补丁在删除的时候避免使用了后继节点来迭代,但是我觉得可能下面的方法更好:
不要删除后继指针,而是把后继节点和要删除的节点位置交换(Relink),再把要删除的节点剥出来,这样后继节点不会因为删除而失效func (rb *RbTree) Delete(n *Node) { erasedNode := n var fixNode, fixNodeParent, pNode *Node pNode = erasedNode if pNode.left == nil { fixNode = pNode.right } else if pNode.right == nil { fixNode = pNode.right } else { pNode = successor(n) fixNode = pNode.right } if pNode == erasedNode { fixNodeParent = erasedNode.parent if fixNode != nil { fixNode.parent = fixNodeParent // link up } if rb.root == erasedNode { rb.root = fixNode // link down from root } else if fixNodeParent.left == erasedNode { fixNodeParent.left = fixNode // link down to left } else { fixNodeParent.right = fixNode // link down to right } } else { //>> pNode is erasedNode's successor, swap(pNode, erasedNode) erasedNode.left.parent = pNode // link left up pNode.left = erasedNode.left // link successor down if pNode == erasedNode.right { fixNodeParent = pNode // successor is next to erased } else { // successor further down, link in place of erased fixNodeParent = pNode.parent // parent is successor's if fixNode != nil { fixNode.parent = fixNodeParent // link fix up } fixNodeParent.left = fixNode // link fix down pNode.right = erasedNode.right // link next down erasedNode.right.parent = pNode // right up } if rb.root == erasedNode { rb.root = pNode // link down from root } else if erasedNode.parent.left == erasedNode { erasedNode.parent.left = pNode // link down to left } else { erasedNode.parent.right = pNode // link down to right } pNode.parent = erasedNode.parent // link successor up pNode.color, erasedNode.color = erasedNode.color, pNode.color // recolor it } if erasedNode.color == BLACK { // erasing black link, must recolor/rebalance tree rb.rbDeleteFixup(fixNode, fixNodeParent) } rb.size-- }
嗯,这个好,有时间再改一下
from gostl.
Related Issues (16)
- 没有实现 unordered_map/unordered_set HOT 1
- Provide findUpprBoundNode method for treemap HOT 2
- a question for Equal() Function in ds/array.go HOT 2
- RbTree.delete invalidate successor pointer when `y != z`
- Can I use generics to implement this library HOT 1
- 红黑树的实现是错的,不能用golang 的nil 作为树的NIL节点 HOT 18
- ds: add EraseIter to Set, MultiSet and MultiMap
- Is it ready for production?
- How to set priority
- 跳表红黑树都不能求rank?
- Question: About Deque
- 单元测试应该断言 HOT 5
- 线程安全还是协程安全? HOT 2
- Create a release tag HOT 1
- improve the ketama HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gostl.