Code Monkey home page Code Monkey logo

Comments (2)

aleDsz avatar aleDsz commented on May 23, 2024

image

I've found the reason, the last section has a : in the name, which is making Phoenix.LiveView.Utils to handle as a URL "scheme" here: https://github.com/phoenixframework/phoenix_live_view/blob/24b6e1be25811fba42664eb9631c4e6b46b89e43/lib/phoenix_live_view/utils.ex#L579-L588

I'll write a hotfix for this.

from livebook.

jonatanklosko avatar jonatanklosko commented on May 23, 2024

Oh yeah, this is not strict enough:

livebook/lib/livebook_web/helpers/html_helpers.ex

Lines 35 to 40 in 4105266

defp name_to_html_id(name) do
name
|> String.trim()
|> String.downcase()
|> String.replace(~r/\s+/u, "-")
end

We should replace anything beyond basic characters |> String.replace(~r/[^\s\w]/u, ""). And if the resulting string is empty, we should also have a fallback, perhaps a hash of the name.

from livebook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.