Improve pagination API for `client.getRooms()` endpoint in `@liveblocks/node` about liveblocks HOT 5 CLOSED

Hey @saiprakash2, we've just released a new option that simplifies this. If we take the original code snippet, you can see the before and after in the snippet below, enabled by nextCursor.

let cursor: string | null = null;

while (true) {
  const resp = await client.getRooms({ startingAfter: cursor });
  doSomethingWithRooms(resp.data);  // current page

  if (resp.nextPage === null) {
    break; // Done paginating
  } else {
    // ❌ Before
    cursor = resp.nextPage.split("startingAfter=")[1].split("&")[0];

    // ✅ After
    cursor = resp.nextCursor;
  }
}

You need to udpate all your packages to 1.9.7 to see this. Find more information under liveblocks.getRooms.

from liveblocks.

Are you talking about improving REST api server responses here instead of updating liveblocks/node client?

Exactly, it would be nicer to have the data available directly instead of having to parse it out in the node client, which feels like a bit of a hack!

Is REST api code open sourced?

Unfortunately the REST API is not open source.

from liveblocks.

Hii @nvie ,
I have one suggestion here. Can't we do this cursor = resp.nextPage.split("startingAfter=")[1].split("&")[0]; in the api itself so that we can send cursor value in the server responses. In that way they dont' have to do the parsing.
If it is null then no more pagination or if it has value then they can use it to fetch the next set of data.
This might be an easy fix.
Please let me know if it works or I will look into it bit more 🙂.

from liveblocks.

Yep! That’s my preferred approach too. We can let the server send those cursor and limit fields back in those responses, right next to the nextPage field with that value in there.

from liveblocks.

Hi @nvie,
Are you talking about improving REST api server responses here instead of updating liveblocks/node client?
Is REST api code open sourced?

from liveblocks.