Code Monkey home page Code Monkey logo

Comments (11)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
I attached a patch that supports management frames, as well as few other types. 
It also has test cases to check the code.

Original comment by [email protected] on 29 Sep 2010 at 6:26

Attachments:

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
 Dear timur alperovich,
 I add nformation elements to your patch. we could talk about the field names that I add. If you want?

Regards,
Sylvain  

Original comment by [email protected] on 12 Oct 2010 at 6:43

Attachments:

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
Hi Sylvain,

I'm a little bit confused because it looks like the latest patch you added was 
a diff against dpkt with your previous patch applied?

I agree that it makes sense to have specific IE names, etc, because right now, 
as you noticed, I just unpack all of them and don't do anything further with 
them (aside from SSID and DS IEs). It would probably make sense to unpack each 
IE with length and ID and use the ID to lookup the appropriate class to unpack 
the rest of it.

I'm guessing that's what you're suggesting to add?

Cheers,
Timur.

Original comment by [email protected] on 13 Oct 2010 at 4:15

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
Hi Timur,

I'm sorry, i attach the wrong file, i made a new patch with your diff,

give me your opinion on it ;)

Regards,
Sylvain 

Original comment by [email protected] on 13 Oct 2010 at 5:28

Attachments:

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
Hi Sylvain,

Looks great. I think that's the right way to do this. Would you mind uploading 
a joint patch next, because none of these have been applied to dpkt and it 
would make sense to combine the changes?

One other thing, could you please add tests to make sure the IE decoding works 
correctly? You can probably craft a very simple packet or even add to the 
beacon packet I have in the prior tests. The tests are important for regression 
testing if there is more code added to the ieee80211 parser (and I'm sure there 
will be).

Thank you,
Timur

Original comment by [email protected] on 13 Oct 2010 at 5:32

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
Hi Timur/Sylvain, 

Is the patch applied in latest revision? Where can I get the complete updated 
files with changes you guys have made?

Thanks,
Arun

Original comment by [email protected] on 6 Jan 2011 at 7:02

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
[deleted comment]

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
Indeed - we'll get this in. Sorry for the delay, guys. There's a missing llc.py 
referenced in the tests; can you post that as well?

Original comment by dugsong on 6 Jan 2011 at 3:38

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
this is the last patch i have done with the lastest revision

Original comment by [email protected] on 6 Jan 2011 at 3:41

Attachments:

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
I have committed llc.py and the changes to ieee80211 that I and Sylvain have 
made.

Arun: the patch is now applied and you can go ahead and use it. Post back if 
you run into problems with it. I fixed one bug, but there could be more :)

Original comment by [email protected] on 6 Jan 2011 at 6:49

from dpkt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024

Original comment by [email protected] on 6 Jan 2011 at 8:39

  • Changed state: Fixed

from dpkt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.