phpunit not found: don't try to guess path to phpunit? about fastest HOT 16 CLOSED

@tarlepp you can invoke with fastest "vendor/bin/phpunit {};" to tell fastest what to execute

from fastest.

@alexislefebvre could you auto assign this and complete the task of editing documentation + tagging and reopen the issue?

from fastest.

@tarlepp have you a real use case for this?

Becase in composer.json we have the line

"config": {
        "bin-dir": "bin/"
    },

that should create a symlink between bin\phpunit and /vendor/phpunit/phpunit/phpunit

Let me know, thank you.

from fastest.

If you're using composer the default actually is vendor/bin/phpunit and bin-dir is an override. Maybe it should check the default location first, or get it from composer config bin-dir ?

from fastest.

@DonCallisto eg. in my project https://github.com/tarlepp/symfony-flex-backend I need to add phpunit symlink to my project bin directory, which seems quite weird.

from fastest.

If you're using composer the default actually is vendor/bin/phpunit and bin-dir is an override. Maybe it should check the default location first, or get it from composer config bin-dir ?

@mtibben I know it's an override but we got this in composer.json file so this should work straightforwardly.

Am I missing something?

from fastest.

I've tried an example and, actually, it does not create a symlink itself. I don't think this should be a feature of this project as every vendor could be placed elsewhere and it could be difficult to find out where. I would suggest to stay with this configuration and run fastest as @mtibben suggested, specifying where phpunit bin is located.

If everyone agree, I'll close this.

from fastest.

@DonCallisto

I know it's an override but we got this in composer.json file so this should work straightforwardly.

Am I missing something?

I think that this part of composer.json is ignored when fastest is installed as a dependency.

from fastest.

@alexislefebvre so, technically, it is useless.

from fastest.

It may be useful when working on this project or when the Travis CI run tests. We can remove this part and see if tests are broken or not.

from fastest.

@alexislefebvre well, you're right, maybe for travis is a crucial parameter. We can try BTW.

However, do you agree with no modification to public static function getDefaultCommandToExecute()?

I suppose it's not a responsibility of this library to discover where the executable is, especially if you can specify it in CLI.

from fastest.

However, do you agree with no modification to public static function getDefaultCommandToExecute()?

I agree but if the removal breaks tests suites of fastest users (because the phpunit executable won't be found), this would be a BC break.

We shouldn't do this in a minor version but it can be done on a major version.

from fastest.

@alexislefebvre let's keep everything as it is now

from fastest.

We can still improve the existing documentation by adding the path to phpunit in every example.

And also reopen and tag this issue as an idea for the future major release.

from fastest.

With the 1.6.x-dev version, this issue is partially solved. It just misses checking in the vendor/bin directory. I will do a PR for this.

from fastest.

Added in the v1.6.0 version.

from fastest.