Upgrade to 3.2.0 about font-awesome-sass-rails HOT 12 OPEN

en, more icons in new version

from font-awesome-sass-rails.

+1

from font-awesome-sass-rails.

I was starting to put together a PR to upgrade to 3.2.x then realized that Font Awesome moved from sass to scss as of the release 3.1.x which brings a question on direction:

A: attempt to generate a sass-compatible version from Font Awesome's new scss files

or

B: migrate over to scss (under a new project?)

Opinions?

from font-awesome-sass-rails.

+1000

from font-awesome-sass-rails.

👍 please :)

from font-awesome-sass-rails.

My vote for option "A" as I use SASS, it requires less typing.

from font-awesome-sass-rails.

SASS option is quite well. +1

from font-awesome-sass-rails.

+1

from font-awesome-sass-rails.

+1, besides it does not really matter since you can mix both (unless they're in the same file)

from font-awesome-sass-rails.

@pduersteler where this matters is that font-awesome is distributed as scss now, so to just "update" would require converting scss to sass. Do you know of any good techniques to convert?

@OShalakhin I don't think the internal format of the font-awesome distribution would affect your usage of sass or scss

My general point is that this gem is called font-awesome-SASS-rails but font-awesome itself now uses SCSS. It would be a lot easier to track upstream releases by using their format IMHO

@littlebtc this is your project - what do you think?

from font-awesome-sass-rails.

@goosetav I see your point. Personally, I'd pick the option that requires less effort to maintain and update the gem. If font awesome is now provided as SCSS, I'd migrate to SCSS for less time-consuming updates.

And, like I said: Since SASS and SCSS are basically from the same set and can be used together (but not in the same file), it doesn't really matter. What, however, may matter, is (as the SASS page states):

Sass has two syntaxes. The new main syntax (as of Sass 3) is known as “SCSS” (for “Sassy CSS”), and is a superset of CSS3’s syntax. This means that every valid CSS3 stylesheet is valid SCSS as well. SCSS files use the extension .scss.

The second, older syntax is known as the indented syntax (or just “Sass”). Inspired by Haml’s terseness, it’s intended for people who prefer conciseness over similarity to CSS. Instead of brackets and semicolons, it uses the indentation of lines to specify blocks. Although no longer the primary syntax, the indented syntax will continue to be supported. Files in the indented syntax use the extension .sass.

So, one point for using SCSS instead of SASS. SCSS is still SASS, so the gem name is still "valid".

I am preparing a pull request to update to v3.2.1.

from font-awesome-sass-rails.

Done, see #37

from font-awesome-sass-rails.