Code Monkey home page Code Monkey logo

Comments (5)

howyay avatar howyay commented on August 12, 2024 1

You are right, I was downloading with Prism launcher, and was convinced that I had downloaded 1.7.2. I then tried 1.7.2 directly from Modrinth website, which did not have this issue with either tall grass or tulips, so I must've been mistaken - sorry for the confusion.

Regardless, here's the relevant log entry on 1.7.3:

[17:49:11] [CullThread/WARN]: Unable to load model: 'minecraft:block/tulip/orange' referenced from: minecraft:white_tulip#: java.io.FileNotFoundException: minecraft:models/block/tulip/orange.json

Aligns well with your proposed solution from earlier.

I also should've noted earlier that orange tulips are fine, its only the non-orange ones that have the missing-texture texture.

Thank you again for your time.

from enhanced-faithcraft.

litoj avatar litoj commented on August 12, 2024 1

No problem, thank you for reporting the issue. I doubt I would have noticed it myself anytime soon.

from enhanced-faithcraft.

litoj avatar litoj commented on August 12, 2024

Hi, this seems really odd. Could you post the logs? It should contain some error message as to what it is missing. I know the short grass naming changed, which is the cause for the tall grass lower half, but I am not aware of a tulip change.

I think this isn't a difficut fix, but I will have to split the releases for 1.20.4+ because of their renaming, so a PR would unfortunately solve only a part of the issue.

from enhanced-faithcraft.

litoj avatar litoj commented on August 12, 2024

The fix is to replace block/grass with block/short_grass in assets/minecraft/models/block/tall_grass_bottom.json and in all assets/minecraft/models/block/3d/flower/*_tulip.json replace block/tulip/orange with block/3d/flower/orange_tulip

the short grass model isn't applied at all also because of the rename, I want to deal with this in the next release, so these fixes might take a little extra time.

from enhanced-faithcraft.

litoj avatar litoj commented on August 12, 2024

Also, are you sure you're on 1.7.2? The tulips broke because of a change I made in 1.7.3.

Sidenote: I am removing the 1.7.3 release, because it doesn't follow semver. I removed a lot of varied textures in there and replaced some with model variation, I will try to keep the old style going without the removal of extra textures alongside my intended direction for people that want more variation and use x32 packs anyway.

from enhanced-faithcraft.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.