[FEATURE_REQUEST] Allow to mount dist/ directory as volume about dashy HOT 7 OPEN

I believe this should be possible by modifying the build command, to include the --no-clean flag ^[docs]

- RUN yarn build --mode production
+ RUN yarn build --mode production --no-clean

I'll test that out this evening, and see if I can get a PR for you :)

from dashy.

Hi @Lissy93 , thank you for the quick reply and taking this on.
I saw the commit, but please correct me if I am wrong (I know nothing of nodejs/yarn/etc), but isn't the issue that docker command is:

build-and-start

Thank build-and-start calls build:

https://github.com/Lissy93/dashy/blob/master/package.json#L14

and that build is missing the flag --no-clean?

https://github.com/Lissy93/dashy/blob/master/package.json#L10

Even if you change the dockerfile the build call above will (try to) remove the directory at runtime?

from dashy.

Basically I tried this change locally (adding a couple of yarn scripts in the package.json):

https://github.com/Lissy93/dashy/compare/master...jecnua:dashy:1570-add-build-no-clean-option?expand=1

And if they are there, in k8s I can override the command and call the no-clean option:

command:
  - yarn
  - build-no-clean-and-start

I am not doing the PR because I understand the change is horrible, and I don't expect to pollute the repo with every single user usecase ^^ But maybe the example can help finding a cleaner solution to allow the no-clean option?

from dashy.

Ah yes, you're right, it should go in the run stage, and not the build stage - so the package.json under build-and-start command would work

from dashy.