Comments (3)
Hey. No, calling ViewHolder.getRoot.getContext()
isn't expensive. Holding quick, cheap, and easy references to a view is the whole point of a ViewHolder! Similarly, it's not expensive to ask a View for its Context.
Your other two issues aren't really related to the library. If you want to have all instances of RowItem use the same CircleTransform, passing it in the constructor sounds like the most correct way to me. If it's just the typing that's tedious, maybe use a factory or a helper method or even dependency injection. There are other ways to handle it, like singletons or a static instance shared for the whole RowItem class.
I also try to avoid holding context in my model objects, or in my adapter, which I consider part of the model. This way it can be reused across configuration changes. If I require a Context
to bind the Item I use the View's context. Of course, nothing is stopping you from extending GroupAdapter
in the same way you were before.
from groupie.
@lisawray cool! Makes complete sense.
Thanks again for the supercool lib!
from groupie.
Glad you like it! I'll close this issue, feel free to open a new one if you have other questions.
from groupie.
Related Issues (20)
- I'm trying to implement. But not some error... HOT 7
- [Crash] ViewPropertyAnimator.java line 1111 - Tmp detached view should be removed from RecyclerView before it can be recycled HOT 2
- [ANR] com.xwray.groupie HOT 1
- Failed to resolve: com.github.lisawray.groupie:groupie:2.9.0 HOT 9
- [Crash] Crashes have occurred as a result of the use of groupie HOT 6
- How not disable recycling for all/some items?
- Support for Jetpack-Compose? HOT 7
- Infinite horizontal scroll HOT 1
- How to switch from list layout to grid layout using groupie ? HOT 1
- androidx.constraintlayout.widget.ConstraintLayout cannot be cast to android.widget.FrameLayout HOT 6
- Is it possible to make ui like Instagram Discover HOT 2
- Groupie Examples Need To Be Updated
- Updating specific section / group
- GroupAdapter item count is misrepresented if empty groups are present
- Vulnerability detected in dependency used for the latest version in Maven Repository: 2.9.0 HOT 1
- getItem(position).notifyChanged(payload)
- I can't remove more than one item in my GroupAdapter.
- Crash com.xwray.groupie.GroupAdapter.onViewDetachedFromWindow GroupAdapter.java, line 261 java.lang.NullPointerException: Attempt to invoke virtual method 'void h8.j.t(h8.i)' on a null object reference
- com.xwray.groupie.GroupAdapter.onViewRecycled java.lang.NullPointerException
- RecyclerView + Groupie , Big Data Will Scroll Slow HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from groupie.