Code Monkey home page Code Monkey logo

Comments (3)

lisawray avatar lisawray commented on September 7, 2024 3

Hey. No, calling ViewHolder.getRoot.getContext() isn't expensive. Holding quick, cheap, and easy references to a view is the whole point of a ViewHolder! Similarly, it's not expensive to ask a View for its Context.

Your other two issues aren't really related to the library. If you want to have all instances of RowItem use the same CircleTransform, passing it in the constructor sounds like the most correct way to me. If it's just the typing that's tedious, maybe use a factory or a helper method or even dependency injection. There are other ways to handle it, like singletons or a static instance shared for the whole RowItem class.

I also try to avoid holding context in my model objects, or in my adapter, which I consider part of the model. This way it can be reused across configuration changes. If I require a Context to bind the Item I use the View's context. Of course, nothing is stopping you from extending GroupAdapter in the same way you were before.

from groupie.

punitda avatar punitda commented on September 7, 2024

@lisawray cool! Makes complete sense.
Thanks again for the supercool lib!

from groupie.

lisawray avatar lisawray commented on September 7, 2024

Glad you like it! I'll close this issue, feel free to open a new one if you have other questions.

from groupie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.