Comments (1)
monokh
commented on May 30, 2024
Hi @jdourlens
Thanks for picking this up!
This has actually been partly addressed in the latest dev branch: 434adff
Apologies that this wasn't present in the master branch. We should make an effort to push the latest changes to master more often.
Having said that, I think you have identified the correct place for this check to go. Additionally the verify call does not do this check in it's current form. So I think as you have pointed out, the check should be introduced in the doesTransactionMatchParams function instead of only within findInitiateSwapTransaction. This also would mean you can find the initiation even before it has succeeded/verified, allowing any consumer to know about it before it is fully confirmed (helpful for UIs for example)
from chainify.
Related Issues (20)
- Cannot read property 'transactions' of null
- Reduce number of HTTP calls made to find a transaction from an account HOT 1
- Issue about examples in chainabstractionlayer HOT 1
- Create EthereumMementoSwapFindProvider HOT 2
- Modify/Extend bitcoin esplora provider to find swaps by contract transactions
- Create EthereumERC20MementoSwapFindProvider
- Provider returned an invalid block, should have required property 'difficulty'
- Update Ledger libraries HOT 1
- Ethereum Swap: Possible to call refund twice HOT 1
- Check for latest scraped block when requesting txs HOT 1
- Getting null pointer exception using BitcoinJSWalletProvider HOT 1
- All providers must be able to find swap transactions from mempool HOT 1
- Sign message malfunction. HOT 1
- getReceivedByAddress missing from BitcoinEsploraApiProvider HOT 1
- Guide to add new chain HOT 1
- Prettier configuration.
- Support for lowR in BitcoinJsWalletProvider HOT 2
- Please use another bitcoin fees API provider HOT 1
- Bitcoin Utils: Validate Address should succeed for proper p2sh-segwit addresses HOT 1
- Fuse network integration HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chainify.