Code Monkey home page Code Monkey logo

Comments (16)

linuz90 avatar linuz90 commented on September 28, 2024

Just tested it and it seems to work. The problem with version 0.3 for me is that it doesn't auto-close the tab anymore, and extension seems to work even when disabled. Are you experiencing this @creold?

from open-in-figma.

creold avatar creold commented on September 28, 2024

@designedbyclu which version of Chrome? Help> About Google Chrome. Do you have the Figma desktop app installed and does the extension just close the tab?

from open-in-figma.

creold avatar creold commented on September 28, 2024

@linuz90 chrome://extensions/ is there any error in version 0.3? I tested new version on the Mac OS High Sierra, Chrome v.69.0.3497.92 (64 bit) and Windows 7, Chrome v.68.0.3440.106 (32 bit). On / off, close the tab, redirect to the Figma app work well. Test video https://dl.dropboxusercontent.com/s/4chre48uxqvtw8v/openfigma_v_0_3.mp4

from open-in-figma.

designedbyclu avatar designedbyclu commented on September 28, 2024

This is my version of Chrome.
image
And my version of "Open in Figma" is 0.2
image
Just downloaded again from the website.

open_in_figma_0 2_failed

from open-in-figma.

designedbyclu avatar designedbyclu commented on September 28, 2024

I just updated my extension to V0.3.
image

Still the same, can't reach to my desktop app
open_in_figma_0 3_failed

from open-in-figma.

creold avatar creold commented on September 28, 2024

I see the problem, it is not in the version of Chrome. For new users we need to intercept this window in the extension, in which we give permission to open the link in the Figma desktop app.

image

from open-in-figma.

designedbyclu avatar designedbyclu commented on September 28, 2024

it's close too fast, i can't allow the permission.

from open-in-figma.

creold avatar creold commented on September 28, 2024

I know. The Extension sent the file to Figma app and closed the tab, but Chrome, due to the security setting, requested permission to open the Figma. I am preparing an update with a solution to this problem.

from open-in-figma.

creold avatar creold commented on September 28, 2024

@designedbyclu , @linuz90 try the new version https://github.com/creold/open-in-figma . It's better to delete the old version before installing the extension version 1.0.

from open-in-figma.

linuz90 avatar linuz90 commented on September 28, 2024

Awesome, I'll check if it works on my Mac tonight or in the weekend (super busy at work rn). If we push it I'll add you as a co-author on the website and on the Chrome store page

from open-in-figma.

designedbyclu avatar designedbyclu commented on September 28, 2024

Working perfectly. Thanks for fix this up.

from open-in-figma.

creold avatar creold commented on September 28, 2024

@designedbyclu after the release of Google Web Store, you can already install the extension from there.

from open-in-figma.

linuz90 avatar linuz90 commented on September 28, 2024

Ok finally had the time to try this. Version 0.3 (already merged here) works perfectly in new Chrome, while version 1.0 doesn't automatically close the tab. Should I just push 0.3 on the Chrome Web Store?

Also not a fan of the setup instructions automatically opening in Chrome. I think the permissions popup just shows every time until you check the option, so it's not really worth showing an entire page with instructions for it. What do you think?

from open-in-figma.

creold avatar creold commented on September 28, 2024

In version 1.0, for tabs to close, you need to activate it once on the options page. I put this in the settings to avoid possible problems with the file type association popup.

If the extension immediately after the installation will automatically close the tabs, then new users will not be able to select an option from the popup “Always open these links associated with this app" option. This is what caused the problem for @designedbyclu.

I now understood, since I removed the automatic closing tab, then a new user can configure a popup for associating file types. And maybe the help page after installation is not needed. Check last commit for v.1.0 https://github.com/creold/open-in-figma.

I would write in Chrome Web Store that the extension v.1.0 has a settings page and that in the popup when the first start the user should activate the checkbox.

from open-in-figma.

creold avatar creold commented on September 28, 2024

@linuz90, hey. Do you plan to make an update 1.0 in the Chrome Web Store? https://github.com/creold/open-in-figma

from open-in-figma.

linuz90 avatar linuz90 commented on September 28, 2024

from open-in-figma.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.