Comments (5)
Ah, it's the old lack of xargs --no-run-if-empty
on MacOS, I think.
Perhaps a while read
loop will do for the inner loop instead, something like:
git grep -E -l "\b$image:" | while read f ; do sed -i.bak -e "s,$image:[[:xdigit:]]\{40\}\(-dirty\)\?,$tag,g" "$f" ; done
will do the job.
from kubernetes.
Or maybe drop the --no-run-if-empty
but add a /dev/null
to the end (so sed
always gets some input file).
from kubernetes.
from kubernetes.
Don't you think we need gsed also?
There's not currently any reason suggested here why we would, but I could believe it would be blocked by the xargs issue since sed
is never actually executed while the problem is present so it might rear its head soon.
If the sed
expression is non-portable (not sure about the portability of [:xdigit:]
for example) then I would rather change it to be portable than require people to install gsed
(and to hack up our build to call it when appropriate).
from kubernetes.
from kubernetes.
Related Issues (20)
- To start the already installed kubernetes cluster HOT 2
- kubelet reports version and v1.9.0-dirty HOT 7
- Upgrade to new version HOT 3
- cri-containerd: hostpath mounted read only HOT 1
- WARN[0003] certificate with CN ABC DEF is near expiry HOT 1
- Flakey rtf tests HOT 1
- Switch from cli configuration to kubelet.conf
- Use noTaintMaster in kubeadm.conf HOT 1
- Investigate and remove rootfsPropagation workaround HOT 1
- Switch to cri as containerd plugin
- Can not boot with head version of linuxkit on macOS HOT 2
- How to set up a development environment? HOT 3
- Kernel panic with "BUG: unable to handle kernel NULL pointer dereference at (null)"
- Use non-hub images
- How to boot automatically ? HOT 1
- containerised kubelet going away HOT 3
- ./ssh_into_kubelet.sh <masterIP> gives /root/.ssh/config: terminating, 1 bad configuration options
- Linuxkit/Kubernetes & Raspberry Pi HOT 2
- Request: update k8s HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubernetes.