Enhance rule triggering with rising and falling edges about linknx HOT 8 OPEN

That could be implemented using this syntax:

<condition type="x" id="x" op="x" value="on" trigger="ontrue | onfalse | always | never">

• ontrue = trigger when going from false to true
• onfalse = trigger when going from true to false
• always = the current trigger="true"
• never = the current trigger="false"

from linknx.

I think I understood what you are trying to achieve. But I may be wrong. What I understood is that at sunrise you want to execute action A if a second condition is true and action B is the second condition is false.
If I got it right, then triggers are not to blame. You can do what you need with two rules (one for sunset when other-condition is true, another for sunset when other-condition is false).
You can certainly do it in a single rule with conditional actions but that seems less natural to me.

If I misunderstood what you are aiming to do, please provide me with a XML sample of your config.

from linknx.

Thank you for your answer !
My explanation may have been a little tricky.
I actually have two different rules. One for sunrise, and one for sunset. Both have a second condition.
So, at sunrise, if condition 2 is true, I want action A to be executed, and if condition 2 is false, I want action B to be executed. And that's the same thing for my other rule evaluated at sunset.
The fact is that if sunrise is at 8:03:00 :
- at 8:02:59 that condition is "false"
- at 8:03:00 that condition becomes "true", then it trigs my rule, which is evaluated as "true" if condition 2 is also true and execute "if-true" actions, or evaluated as "false" if condition 2 is false and execute "if-false" actions --> And that's what I want
- at 8:03:01 that condition becomes "false", then it trigs my rule, which is evaluated as "false" (because "sunrise" condition is now false, no matter my second condition), and execute "if-false" actions --> And that's what I don't want

Here is the XML sample :

<rule id="LeverSoleilOuvrirVolets" description="Ouvrir les volets au lever du soleil si on est absent" init="false" active="yes">
<condition type="and">
<condition type="timer" trigger="true" >
<at  type="sunrise" offset="10" wdays="1234567"></at>
</condition>
<condition type="object" id="Etat_Presence-Absence" op="eq" value="on" trigger="false" ></condition>
</condition>
<actionlist type="if-true">
  <action type="set-value" value="0" id="Position_Volet-Bureau" delay="" ></action>
  <action type="set-value" value="0" id="Position_Volet-SdB" delay="1" ></action>
  <action type="set-value" value="0" id="Position_Volet-Dressing" delay="2" ></action>
  <action type="set-value" value="0" id="Position_Volet-Chambre" delay="3" ></action>
  <action type="set-value" value="0" id="Position_Volet-Salon_fenetre" delay="4" ></action>
  <action type="set-value" value="0" id="Position_Volet-Salon_baie" delay="5" ></action>
  <action type="set-value" value="0" id="Position_Volet-Cuisine" delay="6" ></action>
  <action type="send-email" to="[email protected]" subject="Fermeture volets automatique ${Temps-Date_actuelle}" var="true" delay="" >Lever du soleil, ouverture automatique des volets. Etat absence : ${Etat_Presence-Absence} Etat Jour : ${Scenes_Linknx-Etat_Jour-Soleil_leve_avec_offset}</action>

</actionlist>
<actionlist type="if-false">
  <action type="send-email" to="[email protected]" subject="Fermeture volets non automatique ${Temps-Date_actuelle}" var="true" delay="" >Lever du soleil, mais présent à la maison, donc pas d'ouverture automatique Etat absence : ${Etat_Presence-Absence} Etat Jour : ${Scenes_Linknx-Etat_Jour-Soleil_leve_avec_offset}</action>

</actionlist>
</rule>

from linknx.

So what he wants is the timer condition to only trigger when it goes from False to True and not when it switches from False to True...

from linknx.

OK, that was what I understood from your first description.
The only way I can see to address your need is with the two rules below. (I did not test them, there may be syntax errors...)

<rule id="LeverSoleilOuvrirVolets" description="Ouvrir les volets au lever du soleil si on est absent" init="false" active="yes">
  <condition type="and">
  <condition type="timer" trigger="true" >
    <at  type="sunrise" offset="10" wdays="1234567"></at>
  </condition>
  <condition type="object" id="Etat_Presence-Absence" op="eq" value="on"/>
  </condition>
  <actionlist type="on-true">
        <action type="set-value" value="0" id="Position_Volet-Bureau" delay="" ></action>
        <action type="set-value" value="0" id="Position_Volet-SdB" delay="1" ></action>
        <action type="set-value" value="0" id="Position_Volet-Dressing" delay="2" ></action>
        <action type="set-value" value="0" id="Position_Volet-Chambre" delay="3" ></action>
        <action type="set-value" value="0" id="Position_Volet-Salon_fenetre" delay="4" ></action>
        <action type="set-value" value="0" id="Position_Volet-Salon_baie" delay="5" ></action>
        <action type="set-value" value="0" id="Position_Volet-Cuisine" delay="6" ></action>
        <action type="send-email" to="[email protected]" subject="Fermeture volets automatique ${Temps-Date_actuelle}" var="true" delay="" >Lever du soleil, ouverture automatique des volets. Etat absence : ${Etat_Presence-Absence} Etat Jour : ${Scenes_Linknx-Etat_Jour-Soleil_leve_avec_offset}</action>
  </actionlist>
</rule>
<rule id="LeverSoleilNePasOuvrirVolets" description="Ne pas ouvrir les volets au lever du soleil si on est présent" init="false" active="yes">
  <condition type="and">
  <condition type="timer" trigger="true" >
    <at  type="sunrise" offset="10" wdays="1234567"></at>
  </condition>
  <condition type="object" id="Etat_Presence-Absence" op="eq" value="off"/>
  </condition>
  <actionlist type="on-true">
      <action type="send-email" to="[email protected]" subject="Fermeture volets non automatique ${Temps-Date_actuelle}" var="true" delay="" >Lever du soleil, mais présent à la maison, donc pas d'ouverture automatique Etat absence : ${Etat_Presence-Absence} Etat Jour : ${Scenes_Linknx-Etat_Jour-Soleil_leve_avec_offset}</action>
  </actionlist>
</rule>`

from linknx.

Tagging as enhancement for the record. Stefaan's proposal looks consistent. But we have to handle changes on rules with extra care. Further investigation is required.

from linknx.

Thank you for the enhancement label !
I already thought about your proposal... But that means multiplying rules, and when you need to change a condition, you have to change it in each other rule... That added to my second "feature request", the workarounds are not elegant at all. :-/

I really think that these two enhancements would greatly make linknx more powerful and useful. To me, linknx will reach perfection for my needs...
But you're right to be careful. I was used to code in C++ 15 years ago, and I'm not skilled anymore... And what I could think to be "quite easy" to implement could be in fact very hard... So, I know that what I'm asking you requires a lot of work, and I really appreciate your attention and your help !

from linknx.

Been looking at the documentation of linknx, and you could also do this by putting a condition inside the action:

conditional

One condition child elements that is evaluated when the action is executed.
One or more action child elements to execute if condition above is true.
Example

<action type="conditional">
  <condition type="object" id="alarm_email_enabled" value="on" />
  <action type="send-email"  to="[email protected]" subject="Foreign contaminant">Intrusion in your shrubbery!</action>
</action>

So you just repeat the condition that triggered the event inside the action and you effectively have an "ontrue". By reversing the "value" parameter, you get an "onfalse".

Not ideal (because you have to repeat the condition and remember to make changes to both, but will solve your problem.

from linknx.