Code Monkey home page Code Monkey logo

Comments (6)

gkoo avatar gkoo commented on June 21, 2024

Yeah, that's a pretty common use case. I'll try and get to it sometime this weekend.

from hopscotch.

gkoo avatar gkoo commented on June 21, 2024

Hey Luis, does your onNext callback load the contents of your modal through AJAX? "BeforeShowNextStep" is basically what "onNext" does. Just trying to figure out what your situation is.

from hopscotch.

theSociableme avatar theSociableme commented on June 21, 2024

Any updates on this?

I want "Create a Class" to be pointed at the Input box on the modal.... but since they come up together they end up like this.

image

from hopscotch.

theSociableme avatar theSociableme commented on June 21, 2024

Or somekind of timeout before displaying next..... Might fix this.

from hopscotch.

mjpearson avatar mjpearson commented on June 21, 2024

This seems like a bug... I was able to fix it by hoisting

if (doCallbacks) {
  if (direction > 0) {
    doShowFollowingStep = utils.invokeEventCallbacks('next', origStep.onNext);
  }
  else {
    doShowFollowingStep = utils.invokeEventCallbacks('prev', origStep.onPrev);
  }
}

Out of the changeStepCb closure (L1623) and into the parent changeStep function. The logic in the current version means onNext isn't called until the next steps target can be resolved. Changing the scope gives any onNext functions the opportunity to set up the DOM before trying to attach to the next target.

Can submit a pull request if this seems like an appropriate fix.

from hopscotch.

kate2753 avatar kate2753 commented on June 21, 2024

Rolling this into #56

from hopscotch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.