Comments (7)
Here is an example of scrolling within iframe (JSFiddle uses iframe for the results pane) - http://jsfiddle.net/MvJrL/ .
Are you seeing this issue in a specific browser or all browsers? If you are seeing this in all browsers it's probably an issue with how your page is implemented, because this JSFiddle works for me in latest Chrome and Firefox. If the same JSFiddle is broken in specific browser, then it's likely something we need to fix in hopscotch.
from hopscotch.
I'm running into the same issue with a single page web app
from hopscotch.
Had to fix this on a SharePoint 2013 env. just now. (not an IFrame)
I patched hopscotch.js line 1354 to not scroll on the body but the main DIV
//jQuery('body, html').animate({ scrollTop: scrollToVal }, getOption('scrollDuration'), cb);
$('#s4-workspace').animate({scrollTop: scrollToVal }, getOption('scrollDuration'), cb);
I suggest adding an option "scrollAnchor" set to the default 'body, html'
and then line 1354
jQuery(getOption('scrollAnchor')).animate({ scrollTop: scrollToVal }, getOption('scrollDuration'), cb);
from hopscotch.
I see, step element is within a scrollable parent, so hopscotch tries to scroll body of the page, not the scrollable parent. Here's updated JSFiddle that replicates the behavior http://jsfiddle.net/rm5k2ywk/
We could fix it either by providing scroll anchor for a given step or try to figure out the scrollable parent and scroll it instead of the body of the document. The second option might get complicated an messy when there are several nested scrollable parents, each of which needs to be scrolled.
from hopscotch.
I'm having the same issue. My parent element is a
from hopscotch.
I'm having the same issue. I wish each individual step object had an optional parameter to specify the scrollable container, instead of scrolling the body element.
edit: thinking about it a bit, the scrollAnchor option that @Danny-Engelman is about the same thing. I applied a monkey-patch using the same idea. :)
Only thing to be mindful of is the position of the bubble itself.
from hopscotch.
Im running into same problem, im using the nicescroll to for an div element, the hopscoth is scrolling on the body rather the div element.
Hi @taveras , i also want that monkey-patch for now.
from hopscotch.
Related Issues (20)
- SVGs for sprites?
- Using functions or helpers for target prop
- How to use this library using TypeScript in ng4? HOT 1
- How would I implement a way to cancel the tour if the user navigates away?
- Current step
- FeatureRequest: on-demand Tours
- Hopscotch with tabset
- Issue with going back between multi-site steps between pages
- nextOnTargetClick doesn't work while animating in.
- onStart and onEnd being executed as soon as I start the tour. HOT 1
- How to set up onNext function, when using a database to set up the steps properties? HOT 11
- How to create multiple tours on one page? HOT 5
- sprite-green and sprite-orange don't work HOT 2
- Is it possible to fixe the "popup" on not fixed target
- Customizable theme (background color and text color)
- Visibility for templating and `setRenderer` HOT 1
- Add multiple pages for tour?
- Why previous and Next button displayed after some delay in safari 12.1?
- hopscotch and iframes
- Addclass not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hopscotch.