Comments (1)
moznion
commented on July 17, 2024
First of all, there is no problem even if you forget to append $extraTexts because that is a variadic function via ... (see: http://php.net/manual/en/migration56.new-features.php). That is ensured by this test; this test case doesn't raise error.
And your suggestion has a problem that threatens backward compatibility. A variadic function and a function that has an array default value are different. In other words, your change breaks the signature of function. So we cannot accept your suggestion.
FYI: #58 changes related topic.
from line-bot-sdk-php.
Related Issues (20)
- [Bug Report] An Undefined array key "keywords" error occurs when a StickerMessage has no keywords HOT 1
- [Feature Request] Send multiple messages at once. HOT 2
- Flex Message Update 3 released
- Webhook redelivery HOT 1
- Confirm template has location button is not working HOT 2
- Automatic opening and closing of the rich menu when tapping a rich menu HOT 1
- Added "inputoOption" property to action object HOT 2
- Validate rich menu object HOT 1
- [Bug Report] Placing required parameters after optional parameters is deprecated HOT 1
- [Bug Report] ImageSet event without index/total make Undefined index access HOT 3
- Dependency Dashboard
- fix(ci): set-output in Github Actions to be deprecated
- Validating message objects HOT 1
- [Feature Request] Enable to set `trackingId` via `VideoMessageBuilder` HOT 1
- Get content transcoding status and a preview image HOT 1
- @All in the mention property of the webhooks HOT 1
- [Feature Request] Automatically generate code with github actions when renovate updates
- Add doc
- CI should run openapi-generator, and run test after it
- Methods of Event class are not suggested HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from line-bot-sdk-php.