Comments (6)
After internal review, we decide to reject this PR as it's not very safe to support this kind of option. There cannot be a silver-bullet function to revert an object into the original body buffer.
Rather than this, the case should be handled by using the validateSignature()
function directly.
from line-bot-sdk-nodejs.
By the way, pre-parsed string and buffer cases are handled as I described above.
from line-bot-sdk-nodejs.
Thanks for looking into this. Agree it's not necessary to solve. It's a bad design from Google, and they seems also recognize this: https://issuetracker.google.com/issues/36252545 .
from line-bot-sdk-nodejs.
Thanks for your understanding. Yes, I've checked the issue too. Implementation would be much easier if we could retrieve a raw body.
from line-bot-sdk-nodejs.
I apologize for reopening such an old issue, but just want to point out that there is now a rawBody in the request object for google cloud functions. It should solve this problem if you check for a rawBody key.
https://issuetracker.google.com/issues/36252545
from line-bot-sdk-nodejs.
Great news! Let's do this.
from line-bot-sdk-nodejs.
Related Issues (20)
- Quote Message HOT 3
- Start to implement code generation based on LINE OpenAPI specification HOT 2
- Bump up minor version automatically or semi-automatically HOT 1
- Installing @line/bot-sdk via npm throws an error that says "new line.messagingApi is undefined". HOT 6
- Load Testing Support: Customizable API Endpoints HOT 3
- Deploy docs by github actions
- Use fetch() function instead of axios HOT 4
- Support line login HOT 4
- [BUG] Broken types for webhook.Event in v8 HOT 2
- [BUG]@line/bot-sdk-8.0.1's MessagingApiClient.pushMessage() sends wrong 'Content-Type': 'application/x-www-form-urlencoded', so the pushMessage() throws HTTPError: Request failed with status code 415 HOT 1
- [BUG] VerifyIdToken optional property HOT 2
- [Refactor] Improve Error Handling Consistency and Accessibility in TypeScript Error Classes HOT 13
- Added "ClipboardAction" type to types of actions HOT 3
- [BUG] TypeScript compilation error for generated api client
- Drop node:querystring dependency
- Drop body-parser dependency
- Add support for both ES modules and Common JS HOT 2
- Switch to vitepress
- [Question] : Why there are Unknown typings ? HOT 3
- [BUG] setup webhook following code in example doesn't work anymore HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from line-bot-sdk-nodejs.