Comments (9)
let’s keep it as is for now. i don’t want to introduce breaking changes often (pytorch-lightning)
from pytorch-lightning.
yeah, the problem was that there were issues with the test models being outside of the package.
But if you want to make the change, I do think it would be cleaner. Feel free to submit a PR! It would be super helpful!
Tests will also need to be updated.
from pytorch-lightning.
Awesome PR, thanks for submitting! Interested in looking at any of the other issues we need help with?
from pytorch-lightning.
I was thinking about some workaround automatic testing, formation and coverage...
I will prepare another PR :)
from pytorch-lightning.
amazing! That would be great. Right now a big issue is having to manually run the GPU tests for free.
I'll create an issue to track these changes there
from pytorch-lightning.
I am new to python packages, modules and stuff but I think that now that the directory examples
is in the root, the setup.py
detects it as a package with find_packages()
.
This results in anyone installing your pytorch-lightning
package to also have a examples
package installed into their environment.
As a matter of fact, it is preventing me from loading one of my local module named examples
.
from pytorch-lightning.
The above commit could solve this.
It simply excludes the directory from the package.
Note that it also excludes the tests
which should be causing the same type of problems.
I will proceed with a pull request if it makes sense to you @williamFalcon @Borda.
from pytorch-lightning.
I do agree with the change, or even explicitly name the 'pytorch-lightning'
Btw, why the package is imported pytorch...
not just torch...
such as PyTorch
from pytorch-lightning.
Whitelisting as you suggest seems a good idea BUT doing so, sub-packages will not be imported.
About the name, I also think torch-lightning
makes a lot of sense.
from pytorch-lightning.
Related Issues (20)
- Unable to extend FSDPStrategy to HPU accelerator HOT 7
- SaveConfigCallback.save_config is conflict with DDP HOT 1
- Logging Documentation Does not Detail How to Access the Logged Values during the fit loop
- Apply the ignore of the save_hyperparameters function to args as well.
- Cannot run in SLURM Interactive Session
- Resume from mid steps inside an epoch
- `DDPStrategy` fails when using accelerators other than CUDA
- PyTorch Lightning with T5 Model - RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn HOT 1
- Script freezes when Trainer is instantiated
- Sanitize object params before they get logged from argument-free classes
- Support GAN based model training with deepspeed which need to setup fabric twice HOT 3
- IndexError: Pytorch-lightning CompositionalMetric require tensor.item() if dim=0 whether I did so
- Huge metrics jump between epochs && Step and epoch log not matched, when accumulate_grad_batches > 1
- Does `fabric.save()` save on rank 0? HOT 3
- Turn off hpc checkpoint saving in SLURM environment if trainer.fit(..., ckpt_path="last") HOT 4
- DDP strategy doesn't work for on_validation_epoch_end, always hang HOT 4
- TensorBoardLogger does not document .add_image() function
- Passing a dataloader to save_hyperparams hangs trainer.fit
- If saved_for_backward returns NumberProxy, the value is taken from compile time, not runtime. HOT 1
- logged images are not showing up in tensorboard images.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytorch-lightning.