Code Monkey home page Code Monkey logo

Comments (6)

williamFalcon avatar williamFalcon commented on May 2, 2024 1

https://github.com/williamFalcon/pytorch-lightning/blob/master/pytorch_lightning/models/trainer.py#L137

https://github.com/williamFalcon/pytorch-lightning/blob/master/pytorch_lightning/root_module/model_saving.py#L57

from lightning.

williamFalcon avatar williamFalcon commented on May 2, 2024

@vincentzlt good suggestion. I like the change.

Any takers? @vincentzlt interested in making this change?

from lightning.

Ir1d avatar Ir1d commented on May 2, 2024

i'm interested in this feature, i'll give it a try 😄

from lightning.

williamFalcon avatar williamFalcon commented on May 2, 2024

awesome!

from lightning.

Ir1d avatar Ir1d commented on May 2, 2024

Hi, I have some questions.

I noticed save_function option was deleted in this commit: 63d8428

But how does this line work then? https://github.com/williamFalcon/pytorch-lightning/blob/master/pytorch_lightning/callbacks/pt_callbacks.py#L223-L224

Also, there were some save_function=None in docs, which make it somehow confusing.

from lightning.

williamFalcon avatar williamFalcon commented on May 2, 2024

@vincentzlt https://gitter.im/PyTorch-Lightning/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.