moving examples out of the package about lightning HOT 9 CLOSED

let’s keep it as is for now. i don’t want to introduce breaking changes often (pytorch-lightning)

from lightning.

yeah, the problem was that there were issues with the test models being outside of the package.

But if you want to make the change, I do think it would be cleaner. Feel free to submit a PR! It would be super helpful!

Tests will also need to be updated.

from lightning.

Awesome PR, thanks for submitting! Interested in looking at any of the other issues we need help with?

@Borda

from lightning.

I was thinking about some workaround automatic testing, formation and coverage...
I will prepare another PR :)

from lightning.

amazing! That would be great. Right now a big issue is having to manually run the GPU tests for free.

I'll create an issue to track these changes there

from lightning.

I am new to python packages, modules and stuff but I think that now that the directory examples is in the root, the setup.py detects it as a package with find_packages().

This results in anyone installing your pytorch-lightning package to also have a examples package installed into their environment.

As a matter of fact, it is preventing me from loading one of my local module named examples.

from lightning.

The above commit could solve this.
It simply excludes the directory from the package.

Note that it also excludes the tests which should be causing the same type of problems.
I will proceed with a pull request if it makes sense to you @williamFalcon @Borda.

from lightning.

I do agree with the change, or even explicitly name the 'pytorch-lightning'
Btw, why the package is imported pytorch... not just torch... such as PyTorch

from lightning.

Whitelisting as you suggest seems a good idea BUT doing so, sub-packages will not be imported.

About the name, I also think torch-lightning makes a lot of sense.

from lightning.