Comments (3)
t-vi
commented on July 17, 2024
1
I'm heavily biased towards my fix.
from lightning-thunder.
IvanYashchuk
commented on July 17, 2024
Discovered while working on #595 and the potential fix is 0027c4a
from lightning-thunder.
IvanYashchuk
commented on July 17, 2024
Another fix suggested by @t-vi:
diff --git a/thunder/clang/__init__.py b/thunder/clang/__init__.py
index b2ce62c2..e9bbf7ac 100644
--- a/thunder/clang/__init__.py
+++ b/thunder/clang/__init__.py
@@ -1597,6 +1597,7 @@ def tan(a):
)
+@clangop()
def tanh(a):
return _elementwise_unary_wrapper(
a, prim=prims.tanh, type_promotion_kind=utils.ELEMENTWISE_TYPE_PROMOTION_KIND.INT_TO_FLOATfrom lightning-thunder.
Related Issues (20)
- Create a parametrized benchmark for LitGPT layer norm
- Create a parametrized benchmark for LitGPT RMSNorm
- Create a parametrized benchmark for LitGPT MLP variants
- Create a parametrized benchmark for LitGPT CausalSelfAttention
- Use `time.perf_counter_ns()` instead of `time.time_ns()`
- thunder.core.codeutils.to_printable has RecursionError when input is torch.Size
- type inference: mismatched dtype in cat operator HOT 4
- Support the scatter operator HOT 1
- Unknown attribute _base inside Megatron core HOT 3
- Guard nvFuser-based tests with minimum required compute capability or BF16 capability
- Segmentation fault for fp8 and thunder_cudnn HOT 1
- InterpreterError: Encountered exception TypeError: missing a required argument: 'value' while tracing HOT 3
- Interpreter log colors internal calls
- Support for Python 3.12
- Advanced Indexing with sequences HOT 8
- Apply `thunder.distributed.utils.sort_waits` appropriately when possible HOT 1
- Raise an error when PyTorch's activation checkpointing is used with Thunder-jitted model HOT 2
- _elementwise_binary_helper error when passing a tuple instead of a single value
- Error for falcon-40b from LitGPT
- TypeError: torch_device() got an unexpected keyword argument 'type' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning-thunder.