Code Monkey home page Code Monkey logo

Comments (2)

parthmannan avatar parthmannan commented on September 26, 2024

Another alternative option which doesn't involve nvFuser magically having the context on what is RoPE and what is the best group of ops to send to another executor -

User defined backend as a decorator.

In litGPT for example, if we have a pytorch function that does RoPE, we change the function to something like

@thunder.jit(force_backend=torch_compile_executor)
def apply_rope(inputs):
........

so when thunder is constructing the trace, any operations traced inside this function are pushed to the forced executor backend.

Pros:

  • User gets control over execution
  • Solves pattern matching for at least semi-ninja users. users can do this for anything and use custom kernels registered as backends in Thunder.
  • Alleviates our RoPE perf issues

Cons:

  • Adds complexity to user behavior and usage.
  • Might force changes into how traces are constructed and transforms are done.

from lightning-thunder.

mruberry avatar mruberry commented on September 26, 2024

triage review —

from lightning-thunder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.