Comments (3)
The main reason we chose to use string instead of bytes was so that we abstract away the reversing of the endianness. We previously had it as ba 32-byte slice but it was annoying with extra boilerplate code so we just swapped it out for string to make things easier. Thanks for raising this actually, you made me realise that we're not handling the error returned in some cases. I will add the PreviousTxIDBytes
element to sort that out now. We were considering making all struct elements private and making getters and setters for everything to avoid all this - maybe someday we'll do something like that in v2 or something...
from go-bt.
Hey @caevv, just out of curiosity, what would you need that for?
from go-bt.
I'm storing the tx id as a key on a key/value storage, and as the DB will be huge, by storing the key as bytes, instead of a string, it's saving half of the space.
Now I'm doing this:
key, _ := hex.DecodeString(input.PreviousTxID)
But the implementation on the library seems like it's doing the opposite, so just thought it would save a bit of work.
It's not a blocker for me, just a suggestion.
Thanks.
from go-bt.
Related Issues (20)
- Unlocker improvements
- A nightmare to get the examples running. Release tag matrix from hell [BUG] HOT 5
- Original node software support HOT 1
- GetTxIDBytes HOT 2
- Better signing/unlocking HOT 5
- Struct fields HOT 1
- brc20 transfer question HOT 1
- Standardise/define errors
- Avoid Inputs or Outputs used in insolation
- Support all types of unlocking of scripts and not just signing [ROUGH START]
- Make tx JSON structure consistent HOT 2
- [FEATURE] Multisig Support HOT 2
- [FEATURE] check SIGHASH flags are working properly
- Backport v1 updates into v2 (master) HOT 1
- Refactor to use "signedoff" HOT 1
- [BUG] Parsing error with the interpreter.
- [BUG] Interpreter execution bug HOT 2
- Consistency in opcode casing.
- Improve OP_RETURN handling in interpreter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-bt.