Volume normalization about librespot HOT 8 CLOSED

@cortegedusage Sounds good!
I will prepare a PR for this if @ComlOnline is ok with it.

from librespot.

Yeah that would be great, the only thing I ask is that you add a compile time flag like --features "normalization" as we're discussing in other issues we plan on keeping librespot relatively slimline in its default build state and also have a proper daemon style thing with all the bells and whistles.

from librespot.

@ComlOnline I don't see a point hiding this few lines of code (that don't have any dependencies) behind a compile-time feature flag; also, they are not executed if the command line flag isn't added when running.

@alin23 If you don't mind waiting, I will prepare a pull request in the next days which fixes the edge cases where clipping (distortion) does occur.

from librespot.

@herrernst I can wait ^_^

from librespot.

@herrernst I see your point and you are correct. I didn't see the command line flag, my fault.
My next question is should normalization be the default function and you have to pass a flag to turn it off?
I think most people would unknowingly appreciate this.

from librespot.

I now consider my branch ready for merging: https://github.com/herrernst/librespot/tree/volume-normalization
I wouldn't want this feature enabled by default; the remaining problem is that I'm not able to figure out if an album is played vs. a playlist, so it only applies track-specific normalization. But that is not what you want if you play an album, because you lose inter-track dynamics, and if there are gapless transitions (like a live album), volume would change abruptly when changing tracks.

from librespot.

@herrernst Please could you make a PR?
And I agree about inter track dynamics, usually the album will be mixed so the tracks are complimentary.

from librespot.

Added by #162

from librespot.