Code Monkey home page Code Monkey logo

Comments (4)

dHutchings avatar dHutchings commented on July 17, 2024

There is also a similar problem in the registers.h file.

lines 108 and 109 should be modified to:
"const uint8_t UV_delay_setting [4] = { 1, 4, 8, 16 }; // s
const uint8_t OV_delay_setting [4] = { 1, 2, 4, 8 }; // s"

using just "const int"s breaks the functionality of setCellUndervoltageProtection and setCellOvervoltageProtection.

from bq769x0-arduino-library.

martinjaeger avatar martinjaeger commented on July 17, 2024

Thanks for providing this bug information. Can you send a pull request including the changes?

from bq769x0-arduino-library.

dHutchings avatar dHutchings commented on July 17, 2024

I tried. I do not have permissions to push a new branch to github, which I will need to do to submit a PR. Can you amend please?

from bq769x0-arduino-library.

martinjaeger avatar martinjaeger commented on July 17, 2024

The workflow is as follows:

  • Fork the repository to your personal account.
  • Push changes to your personal repository (the fork).
  • Submit a pull request to merge your changes into the original repository.

from bq769x0-arduino-library.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.