Share menu should have a copy link along side piped, YouTube. about libretube HOT 15 CLOSED

I think long pressing is not really intuitive - I think a dedicated button would be better, that'll require a small redesign of the share dialog though, but I think that's reasonable.

from libretube.

I use URLCheck app for this purpose...not sure this feature is absolute necessary for LibreTube. With URLCheck you can copy, edit & perform multiple custom actions on it.

you can't really make a justification for it not being there because copying links is something we do often and needing third party apps to do it is a bad mark on a great app such as this one

from libretube.

What do you guys think of this design?
If it looks okay, I can raise PR.

from libretube.

I agree. The share menu in some ROMs doesn't have a copy link option as in my case. I'm having difficulty just copying a video link.

There is a small problem when implementing this feature. Which links are supposed to be copied: YouTube or Piped? This will require a solution.

from libretube.

I use URLCheck app for this purpose...not sure this feature is absolute necessary for LibreTube.
With URLCheck you can copy, edit & perform multiple custom actions on it.

from libretube.

I'm not really sure why it doesn't work on other Android ROMs / versions

Actually the problem is with some manufacturers who make stupid modifications in the Android share menu.

I suggest a solution is that long pressing the "YouTube" or "Piped" button copies the link of YouTube/Piped.

from libretube.

I suggest a solution is that long pressing the "YouTube" or "Piped" button copies the link of YouTube/Piped.

Then it will be like a hidden feature that most people will never notice. +1 for Bnyro design idea.
Dedicated copy buttons for Piped and YouTube separately to the right side aligned with the toggle switch.

from libretube.

I think a dedicated button would be better

sure! I suggested the long presss solution because I assumed that you do not have time for a share menu redesign. But yeah it is reasonable.

from libretube.

should I close this issue?

No. GitHub issues are closed when already done by a PR.

from libretube.

Another feature that NewPipe allows is pasting url in search bar and opening that video from link.

from libretube.

New Pipe does that natively.
That's why I suggested. It's a feature suggestion, not a rant. :)
It's a bad design philosophy(To have an extra app just for a single purpose that can easily be native, maybe I'll contribute :) ). See the difference.

I use URLCheck app for this purpose...not sure this feature is absolute necessary for LibreTube. With URLCheck you can copy, edit & perform multiple custom actions on it.

you can't really make a justification for it not being there because copying links is something we do often and needing third party apps to do it is a bad mark on a great app such as this one

• I think it's more about the way share UI is called.

from libretube.

Okay, in fact

from libretube.

Thanks for the draft @amandeepsinghjamwal I planned to do a larger overhaul of the share dialog and already have some drafts for it, I'll probably work on that when I'm back home next week.

from libretube.

I'm not really sure why it doesn't work on other Android ROMs / versions

Actually the problem is with some manufacturers who make stupid modifications in the Android share menu.

I suggest a solution is that long pressing the "YouTube" or "Piped" button copies the link of YouTube/Piped.

oh. thanks. that's dope. love it. (Isn't functional yet.)

from libretube.

What do you guys think of this design? If it looks okay, I can raise PR.

nice. should I close this issue?

from libretube.