Comments (7)
Hey akano12 π π
I agree that the information is there (although a lot of people don't read it). However, for new comers, it is not always easy to navigate through it.
-
It's their fault for not reading.
Also It's not the devs job to spoonfeed everybody, there are tens of thousands of active LibreTube users and i haven't seen anyone asking how to switch an instance. -
How would you know if an instance isn't working? (I'm aware of couple of ways, but asking in the approach you took)
from libretube.
Hey @akano12 π
Considering your points, I thought about a new behaviour that does not block the loading. It just informs the user that the loading is taking more than it's supposed to, and makes it easier for him/her to change the instance - sample below:
sample.mp4
That being said, I think the experience is still not great, since the user has no easy way to reload, without the swiping that I did on the second 16 (the reload is necessary because the ongoing request have the old instance, only by reloading we send the new one).
from libretube.
There's already a flag next to each instance, an explanation what is an instance and in addition to the newly added uptime percentage.
Hence i don't think there should be a change (especially when everything is explained on the first app launch)
from libretube.
Hey akano12 π π
I agree that the information is there (although a lot of people don't read it). However, for new comers, it is not always easy to navigate through it. They just arrived on the App, a look of things to learn. I propose that we guide them, into a working instance. What I propose is something along these lines:
proposal.mp4
from libretube.
Pretty good addon, i have tried implementing this months ago with same snackbar method(embedded button in it) which will redirect to instance setting list but couldn't complete it unfortunately.
from libretube.
I haven't yet dived into that; in the sample, I just added a timeout of X seconds to the requests. If you could share those ways it would be great πͺ
from libretube.
I haven't yet dived into that; in the sample, I just added a timeout of X seconds to the requests. If you could share those ways it would be great πͺ
I truly find there's no optimal way to do this.
-
Simplest one would be checking response code received from the instance on app startup, when switching tabs and when doing any action that requires communication with the instance (almost every action in the app).
This will cause a DoS considering the large amount of users (let alone the number of piped web users) and Spotube and whatever front-end apps that use piped instances -
The way you did, wait for X seconds timeout. Very impractical on slow networks which could take X+1 seconds to load content.
-
What i suggested in an old issue.
Store currently selected instance in shared preferences, fetch list of available instances on app startup and check if the selected instance is available in the list of fetched instances. If it's available do nothing, else notify with a toast.
But take it from me, it's better to leave things as is because whatever logic you want to implement, you have to implement it for each action that communicates with a piped instance. Also bnyro briefly summarized why such implementations cause problems more than advantages
#3924 (comment)
from libretube.
Related Issues (20)
- When playing in audio mode, source error HOT 1
- Enhanced search filters HOT 2
- Media notification playback controls not functioning. HOT 2
- Videos will not stream HOT 1
- Recommendation for Shorts. HOT 1
- Multiple Features Suggestions HOT 1
- setting audio quality "best" doesnt actually change the quality best HOT 2
- Bloqueio do Player
- Melhorias de segurança do LibreTube
- Video resolution is not the same when turning the phone to landscape mode HOT 2
- Libretube is down HOT 3
- SponsorBlock Turns off on its own HOT 1
- Inconsistent Android status bar label color HOT 1
- External Download app advanced option
- Some channels does not show channel banner, profile, subscriber count HOT 1
- Option to hide live streams in feed HOT 3
- Pausing a video in picture-in-picture mode crashes LibreTube HOT 3
- Skip back button skips forward in picture-in-picture mode HOT 1
- Back key does not work while click search option in the Library Watch history page
- fix certain videos timestamps not showing in chapters list HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libretube.