Code Monkey home page Code Monkey logo

Comments (7)

tommyettinger avatar tommyettinger commented on July 24, 2024

This is a good idea I think. The question is really whether minimizejre should care about libraries (lwjglapp and such); I think it shouldn't and should just load a profile from a text file with similar JSON formatting to Packr's run config.

from packr.

badlogic avatar badlogic commented on July 24, 2024

Cool, who's gonna implement it? :)

Am 05.05.2014 16:17, schrieb Tommy Ettinger:

This is a good idea I think. The question is really whether
minimizejre should care about libraries (lwjglapp and such); I think
it shouldn't and should just load a profile from a text file with
similar JSON formatting to Packr's run config.


Reply to this email directly or view it on GitHub
#7 (comment).

from packr.

Murmur avatar Murmur commented on July 24, 2024

Valid point tommyettinger, packr should not really care about random applications. Profile text file "minimizejre=default-minimize.txt" would do the trick just fine and everyone is happy. Provide default file as an example.

This does not happen without some effort, probably should contain few syntax tricks.
jar://some/lib.jar:/path/inside/packet/
jar://some/lib.jar:/some/file/delme.class
file://some/path/
file://some/file/delme.exe
file://some/wildcard/*.exe

default-minimize.txt syntax sugar ideas:
jar://jre/lib/rt.jar:/com/sun/corba/
jar://jre/lib/rt.jar:/com/sun/jmx/
jar://jre/lib/rt.jar:/com/sun/some/specific/file.class
file://jre/lib/rhino.jar
file://jre/bin/client/
file://jre/bin/*.exe

from packr.

tommyettinger avatar tommyettinger commented on July 24, 2024

@badlogic: Me. Me implemented it (I think!). #8 @Murmur, if you want to test it out, the config file it uses only supports paths within rt.jar for now (since that's all that was being removed and was really questionable whether it's desirable or not, other than Rhino. The syntax is just lines like:
jre/lib/rt/com/sun/corba
jre/lib/rt/sun/applet
to remove. It might support paths out of rt.jar, now that I think of it, but it also deletes rhino.jar automatically, so that would be bad to delete twice.

from packr.

badlogic avatar badlogic commented on July 24, 2024

I'm gonna be super mean and tell you that i have a slightly different idea
for this. currently out and about, will get back to you tonight or tomorrow.

thanks for taking initiative on this!

On Monday, May 5, 2014, Tommy Ettinger [email protected] wrote:

@badlogic https://github.com/badlogic: Me. Me implemented it (I
think!). #8 #8 @Murmurhttps://github.com/Murmur,
if you want to test it out, the config file it uses only supports paths
within rt.jar for now (since that's all that was being removed and was
really questionable whether it's desirable or not, other than Rhino. The
syntax is just lines like:
jre/lib/rt/com/sun/corba
jre/lib/rt/sun/applet
to remove. It might support paths out of rt.jar, now that I think of it,
but it also deletes rhino.jar automatically, so that would be bad to delete
twice.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-42211606
.

from packr.

badlogic avatar badlogic commented on July 24, 2024

NM, what you implemented in 8 is exactly what i had in mind! i'd even go so
far and simply add default config files as resources. if minimizejre
doesn't resolve to a file, we check the classpath. lot easier to maintain
and extend and the code in Packr.java stays minimal.

Thoughts?

On Monday, May 5, 2014, Mario Zechner [email protected] wrote:

I'm gonna be super mean and tell you that i have a slightly different idea
for this. currently out and about, will get back to you tonight or tomorrow.

thanks for taking initiative on this!

On Monday, May 5, 2014, Tommy Ettinger <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

@badlogic https://github.com/badlogic: Me. Me implemented it (I
think!). #8 #8 @Murmurhttps://github.com/Murmur,
if you want to test it out, the config file it uses only supports paths
within rt.jar for now (since that's all that was being removed and was
really questionable whether it's desirable or not, other than Rhino. The
syntax is just lines like:
jre/lib/rt/com/sun/corba
jre/lib/rt/sun/applet
to remove. It might support paths out of rt.jar, now that I think of it,
but it also deletes rhino.jar automatically, so that would be bad to delete
twice.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-42211606
.

from packr.

badlogic avatar badlogic commented on July 24, 2024

I pulled in @tommyettinger PR and fixed it up to work as i explained in my last message.

Packr stores a few profiles internally as resource files (soft, hard). A user can specify her own profile file via the minimizejre parameter. If the file isn't found, packr falls back to resolving it from the resources. Updated README.md accordingly.

from packr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.