Code Monkey home page Code Monkey logo

Comments (3)

omgitsraven avatar omgitsraven commented on September 23, 2024 1

I think the issue might be that it relates to the dimensions at all -- I think typically a setting like resolution would refer to a certain amount of detail per unit, regardless of how many units large the document is. So it's more like each axis should get a certain number of subdivisions multiplied by its size.

from libfive.

mkeeter avatar mkeeter commented on September 23, 2024

This is a somewhat confusing side-effect of how we pick the max subdivision level in region.hpp:

    /*
     *  Returns a version of this region that has the level set
     *  based on the given minimum feature.
     *
     *  This lets us do subdivision without worrying that the termination
     *  condition (of a cell side being < min_feature) is dependent on
     *  floating-point accuracy.
     */
    Region<N> withResolution(double min_feature) const {
        const auto min_dimension = (upper - lower).minCoeff();
        const auto level = ceil(fmaxf(0.0f, logf(min_dimension / min_feature)) /
                                logf(2));
        return Region<N>(lower, upper, perp, level);
    }

The number of octree subdivisions is set by the lowest dimension, so I think that going from [10, 10] → [-1, 6] must be reducing it in your example.

Maybe it should be set by the largest dimension instead?

from libfive.

Wulfsta avatar Wulfsta commented on September 23, 2024

I agree that this should be per unit, and not dependent on the size of the bounding box. It also has a huge impact on exported STL size - settings that produce no artifacts with a smaller bounding box produce significantly larger files (multiple GiBs in my case), whereas a bounding cube produces no artifacts at default settings and order of magnitude smaller files.

from libfive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.